-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates logo scss to regard default values and updates favicon upload check #10963
Conversation
For me the failed tests look unrelated. But someone should double check. |
I restarted the tests. It looks unrelated yes :) |
@juliushaertl yes sure if it is a regression lets do it. Changes are minor it seems. |
All right, created a backport PR for the first commit, since that is the important one to fix the regression: #11048 |
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
bfc638b
to
38ea5d1
Compare
Rebased |
@weeman1337 do you know, should this go into 14 too? |
@nickvergessen I think #11055 should go to. |
@juliushaertl Any comments why you closed it? |
@juliushaertl 🏓 ;) |
Logo
With the change from here: e8938df the scss variables from theming were overwritten by the value in the variables.scss.
This fix adds support for default values to the logo and background scss.
Favicon
SVG favicons are not working if they're SVG and imagemagick isn't present. There is already a notice on the theming page, but the user is still able to upload a SVG favicon. I changed this so the upload returns "unsupported image type" for SVG favicons without imagemagick.
Closes #10957