Make php7.3 compatible #11745
Merged
Make php7.3 compatible #11745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
same issue as in #11746 Will fix once that is in |
It is merged. |
|
rebased |
rullzer
added
3. to review
MorrisJobke
reviewed
Oct 11, 2018
lib/versioncheck.php
Outdated
| // Show warning if > PHP 7.2 is used as Nextcloud is not compatible with > PHP 7.2 for now | ||
| if (version_compare(PHP_VERSION, '7.3.0') !== -1) { | ||
| // Show warning if > PHP 7.3 is used as Nextcloud is not compatible with > PHP 7.3 for now | ||
| if (version_compare(PHP_VERSION, '7.4.0') !== -1) { | ||
| http_response_code(500); | ||
| echo 'This version of Nextcloud is not compatible with > PHP 7.2.<br/>'; |
There was a problem hiding this comment.
This also needs to be updated.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst,
nickvergessen,
icewind1991 and
juliusknorr
nickvergessen
approved these changes
Oct 11, 2018
MorrisJobke
approved these changes
Oct 11, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.