Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14] php7.3 CI #11790

Merged
merged 2 commits into from
Oct 12, 2018
Merged

[14] php7.3 CI #11790

merged 2 commits into from
Oct 12, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Oct 12, 2018

backport of #11745

@rullzer
Add 7.3 CI to drone
bddf937 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Allow php7.3
e7d20cd 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review Waiting for reviews label Oct 12, 2018
@rullzer rullzer added this to the Nextcloud 14.0.4 milestone Oct 12, 2018
@MorrisJobke
Copy link
Member

I would also love to see the acceptance tests to be run on PHP 7.3 🙈

@rullzer
Copy link
Member Author

rullzer commented Oct 12, 2018

@MorrisJobke agreed. I think they still run on 7.1 actually 🙊

@MorrisJobke
Copy link
Member

I would also love to see the acceptance tests to be run on PHP 7.3 🙈

But something for another PR.

@rullzer rullzer merged commit 91c44c8 into stable14 Oct 12, 2018
@rullzer rullzer deleted the backport/11745/stable14 branch October 12, 2018 13:32
@timm2k timm2k mentioned this pull request Nov 7, 2018
Closed
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
Merged
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 14.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@rullzer @MorrisJobke @nickvergessen @blizzz