issue: external storage naming #11755 #12049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
reviewed
Oct 29, 2018
| @@ -43,6 +43,7 @@ | |||
| "Storage with ID \"%d\" not found" : "Storage with ID \"%d\" not found", | |||
| "Invalid backend or authentication mechanism class" : "Invalid backend or authentication mechanism class", | |||
| "Invalid mount point" : "Invalid mount point", | |||
| "Invalid path of mountpoint" : "Invalid path of mountpoint", | |||
There was a problem hiding this comment.
This is not required. Our translation scrips sync this auytmaitcally to transifex for translations
There was a problem hiding this comment.
Should I remove it from PR?
There was a problem hiding this comment.
Yes - the automatic script will update it and the translations are stored on transifex anyways.
Signed-off-by: Rinat Gumirov <rinat.gumirov@mail.ru>
MasterOfDeath
force-pushed
the
external-storage-naming
branch
from
4bb6407 to
1d94492
Compare
MorrisJobke
reviewed
Oct 29, 2018
| @@ -45,6 +45,7 @@ OC.L10N.register( | |||
| "Storage with ID \"%d\" not found" : "Storage with ID \"%d\" not found", | |||
| "Invalid backend or authentication mechanism class" : "Invalid backend or authentication mechanism class", | |||
| "Invalid mount point" : "Invalid mount point", | |||
| "Invalid path of mountpoint" : "Invalid path of mountpoint", | |||
|
@icewind1991 I would like to have your feedback on this one. |
|
@icewind1991 ping |
|
I'm going to clos this here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation for existing mountpoint path
fixes #11755