Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove LDAP::hasPagedResultSupport() from PHP < 5.4 days #12053

Merged
merged 1 commit into from
Oct 26, 2018
Merged

remove LDAP::hasPagedResultSupport() from PHP < 5.4 days #12053

merged 1 commit into from
Oct 26, 2018

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Oct 25, 2018

/me coughs out all the dust ;) Resolves #10923

@blizzz
functions that were checked for are present since PHP 5.4, supported …
2048872 
…is >=/

* so the check from older days is really not necessary anymore
* resolves #10923

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 15 milestone Oct 25, 2018
@blizzz
Copy link
Member Author

blizzz commented Oct 25, 2018

failing tests are unrelated

rullzer
rullzer approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY for cleanup

Didn't test but makes sense

@blizzz
Copy link
Member Author

blizzz commented Oct 26, 2018

My smoke testing went fine. If there were issues also pagination related integration tests should failfail, they don't.

MorrisJobke
MorrisJobke approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit 7aa76a8 into master Oct 26, 2018
@MorrisJobke MorrisJobke deleted the enhancement/10923/remove-unncessary-check branch October 26, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: ldap technical debt
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
3 participants
@blizzz @rullzer @MorrisJobke