Make acceptance tests for comments more robust #12649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the "Comments" tab is open the empty content element is always in the DOM, although it is only shown once the message collection was fetched and there were no messages. Due to this it is necessary to explicitly wait for it to be shown instead of relying on the implicit wait made to find the element; otherwise it would be found immediately and if the collection was not fetched yet it would not be visible, causing the test to fail. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
If the server is too slow, changing to a different file immediately after sending a new comment but without waiting for the comment to be shown for the original file could cause the new comment to be shown for the current file instead. This is, indeed, a bug in the comments. However, it is not possible to test it reliably in the acceptance tests, as it depends on how fast the server adds the message and how fast the client changes to a different file; sometimes the test would fail and sometimes it would not. Therefore, now it is waited for the comment to be added before changing to another file, as in this case it can be reliably tested that changing to a different file does not cause the comments from the previous file to be shown in the current file (this was a different bug already fixed and due to which this test was added in the first place). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to 15 |
|
/backport to 14 |
rullzer
approved these changes
Nov 25, 2018
MorrisJobke
approved these changes
Nov 26, 2018
MorrisJobke
deleted the
make-acceptance-tests-for-comments-more-robust
branch
|
/backport to 15 |
|
/backport to 14 |
|
/backport to stable15 |
|
backport to stable15 in #12696 |
|
/backport to stable14 |
|
backport to stable14 in #12697 |
|
Well, this is embarrassing xD Thanks @danielkesselberg for the correct commands :-) |
|
Hmm. I guess the bot should not react with 👍 when he does not understand the command 😕 |
I agree: nextcloud/backportbot#13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
sleep(2)to the beginning ofgetChild()in apps/dav/lib/Comments/RootCollection.phpResult with this pull request:
All tests pass
Previous result:
open the comments for a different file failed due to the empty content message not having being shown yet when looking for it and not waiting for it to be shown, write a comment in a file right after writing a comment in another file failed due to Comment in Folder being shown in welcome.txt.
This last failure is actually a bug in the comments, but one that can not be reliably tested with the acceptance tests due to depending on how fast the server creates the new comment. Therefore, the scenario now waits for the comment to be added to the first file before continuing; this still verifies that changing to a different file does not cause the comments from the previous file to be shown in the current file (this was a different bug already fixed and due to which this test was added in the first place), although it no longer verifies that changing to a different file while the comment is being sent does not cause the comment from the previous file to be shown in the current file (subtle difference, but needed for the reliability of the tests ;-) ).