Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exemptions for incompatible UAs #1328

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Conversation

LukasReschke
Copy link
Member

Some user agents are notorious and don't really properly follow HTTP
specifications. For those, have an automated opt-out. Since the protection
for remote.php is applied in base.php as starting point we need to opt out
here.

Fixes #223
Fixes #1237

In combination with #797

@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Sep 8, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Sep 8, 2016
@mention-bot
Copy link

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @bartv2 and @icewind1991 to be potential reviewers

Some user agents are notorious and don't really properly follow HTTP
 specifications. For those, have an automated opt-out. Since the protection
for remote.php is applied in base.php as starting point we need to opt out
here.
@icewind1991
Copy link
Member

👍 looks good

@MorrisJobke
Copy link
Member

Tested and works 👍

@MorrisJobke MorrisJobke merged commit d8c4f18 into master Sep 8, 2016
@MorrisJobke MorrisJobke deleted the add-exemption-for-osx branch September 8, 2016 16:39
@MorrisJobke
Copy link
Member

@LukasReschke @karlitschek Backport to stable10?

@ochurlaud
Copy link

Just tested, it still does not work in my case with the last DAVdroid (1.3-ose) and KOrganizer.

The only problem is about the calendar and contacts synchronization. Mail sent to Lukas for more tests.

@LukasReschke
Copy link
Member Author

@LukasReschke @karlitschek Backport to stable10?

Should do that. Will create a PR containing both issues.

@LukasReschke
Copy link
Member Author

LukasReschke commented Sep 8, 2016

=> #1331

@karlitschek
Copy link
Member

please backport 👍

@Chluz
Copy link

Chluz commented Jan 29, 2017

Hi, Coming from the KeeWeb issues thread keeweb/keeweb#492 , adding the following exception for incompatible user agents fixed the KeeWeb 1.3.3 webdav client using nextcloud 11.0.1:

             $incompatibleUserAgents = [
                        // OS X Finder
                        '/^WebDAVFS/',
                        // KeeWeb client
                        '/KeeWeb\/\d[.]\d[.]\d/',
                ];

Is this something worth making a fork/merge request for ?

@MorrisJobke MorrisJobke mentioned this pull request Jan 30, 2017
59 tasks
@huguesgr
Copy link

Can anyone reply to @Chluz?
After each Nextcloud upgrade, I have to add the KeeWeb regex, otherwise it breaks KeeWeb synchronisations.

@acidsploit
Copy link

Yes, please fix this.

@Chluz @Wohlraj I'm having the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants