-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exemptions for incompatible UAs #1328
Conversation
@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @bartv2 and @icewind1991 to be potential reviewers |
Some user agents are notorious and don't really properly follow HTTP specifications. For those, have an automated opt-out. Since the protection for remote.php is applied in base.php as starting point we need to opt out here.
1d15e27
to
6ac8908
Compare
👍 looks good |
Tested and works 👍 |
@LukasReschke @karlitschek Backport to stable10? |
Just tested, it still does not work in my case with the last DAVdroid (1.3-ose) and KOrganizer. The only problem is about the calendar and contacts synchronization. Mail sent to Lukas for more tests. |
Should do that. Will create a PR containing both issues. |
=> #1331 |
please backport 👍 |
Hi, Coming from the KeeWeb issues thread keeweb/keeweb#492 , adding the following exception for incompatible user agents fixed the KeeWeb 1.3.3 webdav client using nextcloud 11.0.1:
Is this something worth making a fork/merge request for ? |
Can anyone reply to @Chluz? |
Yes, please fix this. @Chluz @Wohlraj I'm having the same issue. |
Some user agents are notorious and don't really properly follow HTTP
specifications. For those, have an automated opt-out. Since the protection
for remote.php is applied in base.php as starting point we need to opt out
here.
Fixes #223
Fixes #1237
In combination with #797