Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match only for actual session cookie #797

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

LukasReschke
Copy link
Member

OVH has implemented load balancing in a very questionable way where the reverse proxy actually internally adds some cookies which would trigger a security exception. To work around this, this change only checks for the session cookie.

Fixes #223 (Nextcloud on OVH "Cloud Hosting")


@hameau @voidzero @ksmolder @ochurlaud Please test. Thanks a lot.

OVH has implemented load balancing in a very questionable way where the reverse proxy actually internally adds some cookies which would trigger a security exception. To work around this, this change only checks for the session cookie.
@lGuillaume124
Copy link

Hello,
In which way is it a "questionable" method?

@hameau
Copy link

hameau commented Aug 11, 2016

@LukasReschke : I will try to test in the next few days.
@lGuillaume124 : Tu es chez OVH, je croix ? Heureux de te voir ici.

@ochurlaud
Copy link

@LukasReschke Any comments on that?

@CATER-COM
Copy link

Hi,

I use for professional activity and personal activity OVH shared hosting. The professionnal cloud use Owncloud 8.0.3 (on OVH performance plan) with no problems at all (I cannot migrate to Nextcloud until it will be stable on OVh shared hosting). My personal cloud use Nextcloud 10 (on OVH 90plan), migrated from OC8.0.3 throught OC 8.2, and NC 9. My 90plan will move to Pro or Performance plan in the next days.

All seem to work well on WebUI. I got some problems to sync with external app (Thunderbird Cal and Carddav), with the Nextcloud Android App (Unknown error... in fact a 503 error on HTTP request), with DAVdroid, and with Gnome webdav integration on Ubuntu.

The patch solved the problem with the Nextcloud Android app. But

  • Webdav in Gnome not working "HTTP error : Service Unavailable"
  • Caldav with DAVdroid discover the calendar (with full address) but does not sync or show any thing
  • Carddav with DAVdroid discover the addressbook (with full address) but does not sync or show any thing
  • Caldav with Caldav Sync Adapter seem to work perfectly !!!!
  • Caldav with Thunderbird Lightning seem to work perfectly
  • Carddav with Thunderbird Lightning seem to work perfectly

I does not found alternative carddav adapter on F-Droid to test it.

I hope it could help. I prefer to keep Nextcloud and migrate my professional cloud, but in both case we need contacts on our phones so I hope that the solution will be found.

Cédric.

@CATER-COM
Copy link

Sorry copy/past mistake :
"Carddav with Thunderbird and Sogo connector seem to work perfectly"

@CATER-COM
Copy link

I get some time 503 error from Caldav sync adapter but it sync the calendar at the end.

@CATER-COM
Copy link

Sync file via Owncloud Desktop client on Ubuntu 14.04 seem to work well.

@MorrisJobke
Copy link
Member

I tested the app here and it still works 👍

@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Aug 31, 2016
@MorrisJobke
Copy link
Member

cc @nickvergessen @rullzer for review

@rullzer
Copy link
Member

rullzer commented Aug 31, 2016

Ah yes forgot to 👍
It feels so dirty but my instance did not explode or unlesae cthulhu

@nickvergessen nickvergessen merged commit f9cea0b into master Aug 31, 2016
@nickvergessen nickvergessen deleted the only-match-for-auth-cookie branch August 31, 2016 13:59
@ochurlaud
Copy link

@nickvergessen it is stupid (no offense) to merge this like this, since it didn't solve the problem..... Maybe we could dig further and find a correct patch?

@nickvergessen
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants