-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match only for actual session cookie #797
Conversation
OVH has implemented load balancing in a very questionable way where the reverse proxy actually internally adds some cookies which would trigger a security exception. To work around this, this change only checks for the session cookie.
Hello, |
@LukasReschke : I will try to test in the next few days. |
@LukasReschke Any comments on that? |
Hi, I use for professional activity and personal activity OVH shared hosting. The professionnal cloud use Owncloud 8.0.3 (on OVH performance plan) with no problems at all (I cannot migrate to Nextcloud until it will be stable on OVh shared hosting). My personal cloud use Nextcloud 10 (on OVH 90plan), migrated from OC8.0.3 throught OC 8.2, and NC 9. My 90plan will move to Pro or Performance plan in the next days. All seem to work well on WebUI. I got some problems to sync with external app (Thunderbird Cal and Carddav), with the Nextcloud Android App (Unknown error... in fact a 503 error on HTTP request), with DAVdroid, and with Gnome webdav integration on Ubuntu. The patch solved the problem with the Nextcloud Android app. But
I does not found alternative carddav adapter on F-Droid to test it. I hope it could help. I prefer to keep Nextcloud and migrate my professional cloud, but in both case we need contacts on our phones so I hope that the solution will be found. Cédric. |
Sorry copy/past mistake : |
I get some time 503 error from Caldav sync adapter but it sync the calendar at the end. |
Sync file via Owncloud Desktop client on Ubuntu 14.04 seem to work well. |
I tested the app here and it still works 👍 |
cc @nickvergessen @rullzer for review |
Ah yes forgot to 👍 |
@nickvergessen it is stupid (no offense) to merge this like this, since it didn't solve the problem..... Maybe we could dig further and find a correct patch? |
OVH has implemented load balancing in a very questionable way where the reverse proxy actually internally adds some cookies which would trigger a security exception. To work around this, this change only checks for the session cookie.
Fixes #223 (Nextcloud on OVH "Cloud Hosting")
@hameau @voidzero @ksmolder @ochurlaud Please test. Thanks a lot.