Increase max read #16946
Increase max read #16946
Conversation
|
Thank you 👍 Mind to sign off your commits? https://github.com/nextcloud/server/pull/16946/checks?check_run_id=208487803 for more information. |
kesselb
added
3. to review
|
So I actually tried this and for me it made no difference. As the files are read in 8kb chunks anyways (php internals). did you change other things as well? |
|
I guess thats kinda the point. You shouldn't notice a difference. In my set up this stopped bandwidth by a huge amount. I only looked at this being an issue because of the huge bandwidth usage on my server. This fixed it for me |
|
See above for bandwidth screenshot. Before and after this change. One of the last 2peaks was me testing the fix. Other was was downloading a massive file. Just changed these two lines for this effect |
|
@exussum12 I meant that I still saw 8k reads originating from php 😉 as that is one of the internal constants. I'll dive a bit deeper. |
|
Have you got a link to that source? I did take a look but didn't find it. I imagine its there in the context of IP packets and not disk read bytes as many disks actually have larger block sizes than this also now. (Though this effect will be much less noticeable on a disk itself ) |
Mmm I can only trigger it in docker on old php versions. |
|
@exussum12 could you change the chunkSize to 512 kB (524288) as requested and rebase the branch with the latest changes from master? Thanks 👍 |
exussum12
force-pushed
the
patch-1
branch
2 times, most recently
from
2080f87 to
79fa714
Compare
|
Thanks @exussum12 👍 CI looks good. I restarted the Job because some timeouts. |
|
Hey @exussum12, mind to do another rebase? |
8kb is very low, especially given this will be local files Signed-off-by: Scott Dutton <scott@exussum.co.uk>
|
rebased @kesselb |
lib/private/Files/View.php
Outdated
| @@ -423,7 +423,7 @@ public function readfile($path) { | |||
| @ob_end_clean(); | |||
| $handle = $this->fopen($path, 'rb'); | |||
| if ($handle) { | |||
| $chunkSize = 8192; // 8 kB chunks | |||
| $chunkSize = 512000; // 500 kB chunks | |||
There was a problem hiding this comment.
should be 524288 as per #16946 (comment)
There was a problem hiding this comment.
Ah sorry. I think I rebased from a commit without this
|
The lint check is failing on lines I've not touched ? |
yeah not your fault. new linter |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
8kb is very low, especially given this will be local files. a fix for #16945