-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to edit admin/own user in the user management #18555
Conversation
juliusknorr
commented
Dec 23, 2019
•
edited
Loading
edited
- Fix own user editing (Fixes Editing my user via user managment not possible #18530, Fixes Current user cannot edit groups (18RC2) #18964, Fixes NC18 - can not change own passwd / group #19004, Fixes Can not change admin settings #19072)
- Fix height of user rows
- Fix missing submit button in the display name field
- Fix group navigation (regression from Migrate to @nextcloud/vue 1.x.x #18917) No backport needed for this
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Login as admin
- Go to user management
- Enter editing mode for yourself
- Try to leave it (seems to work for any other user)
It seems that you currently cannot save when editing your own user.
server/apps/settings/src/components/UserList/UserRow.vue
Lines 211 to 218 in 32d279d
<div class="userActions"> | |
<div v-if="OC.currentUser !== user.id && user.id !== 'admin' && !loading.all" | |
class="toggleUserActions"> | |
<Actions> | |
<ActionButton icon="icon-checkmark" | |
@click="editing = false"> | |
{{ t('settings', 'Done') }} | |
</ActionButton> |
This comment has been minimized.
This comment has been minimized.
Ping :) |
master is NC19 now. |
Conflicts 😨 |
🏓 |
Anyone still alive fixing this? |
Yes, I was waiting for #19533 to be merged before doing another rebase dance. |
32d279d
to
1a8ee2f
Compare
All comments should be addressed, editing the own user is now limited to admin users as it is done in the backend. Ready for review. |
Also anything related to showing quota seems to be broken. It seems to be possible to change the quota but not what quota is currently selected. But that's probably fixed by #18818. |
Oh joy, but yes, let's try to address that in #18818 then. Same for the others. I can look into those, maybe you could create an issue for them, so I have a list rather than picking up pr comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looked at the code. LGTM.
P.S. Never seen a computed returning a function before. Interesting.
Yeah the benefit of that is that the result is still cached, so it will only update if the dependency changes in contrast to a method. |
f833d99
to
6f932ca
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
6f932ca
to
b9d5186
Compare
I seem to be missing something here: I just installed 18.0.3 and still I can't edit my own user (no pencil icon). I need that e.g. to be able to assign myself to new groups. Currently, my (clumsy) workaround is to impersonate another admin and modify my user there… Apart from the huge vertical space for each user … I HAD an entry with MANY test groups since these were shown within other user lines in 18.0.0. Is it possible that the height is still calculated from the biggest (now deleted) entry? |
I confirm that. |
yeah 18.0.3 is a release with just a security fix. |
@ rullzer
|
@vincentstans what part of "18.0.3 is a release with just a security fix" did you not understand? |
Works fine in 19 beta 5, thanks! |