fixing php 32 bit (arm) filemtime on large file issue (#18971) (#25428) #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return false; | ||
| } | ||
| if (PHP_INT_SIZE === 4) { | ||
| return (int) exec ('stat -c %Y '. escapeshellarg ($fullPath)); |
There was a problem hiding this comment.
Should IMO be in \OC\LargeFileHelper
LukasReschke
previously requested changes
Oct 25, 2016
| return false; | ||
| } | ||
| if (PHP_INT_SIZE === 4) { | ||
| return (int) exec ('stat -c %Y '. escapeshellarg ($fullPath)); |
LukasReschke
force-pushed
the
downstream-25428
branch
from
39acdec
to
ea00bca
Compare
|
I changed this as pointed out. 👍 from me now. |
|
Much cleaner 👍 |
nickvergessen
added
4. to release
|
Lets do this |
LukasReschke
previously requested changes
Oct 25, 2016
| */ | ||
| public function getFileMtime($fullPath) { | ||
| if (\OC_Helper::is_function_enabled('exec')) { | ||
| return $this->exec('stat -c %Y ' . escapeshellarg($fullPath)); |
There was a problem hiding this comment.
Fails on OS X so we also need some more fallbacks here as it may also fail on other BSD and Linux derivates here. Awesome 🚀
nickvergessen
added
1. to develop
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
force-pushed
the
downstream-25428
branch
from
ea00bca
to
62bb991
Compare
LukasReschke
added
3. to review
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @icewind1991 @rullzer @nickvergessen