fixing php 32 bit (arm) filemtime on large file issue (#18971) #25428
Conversation
|
@cyberb, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @icewind1991 and @PVince81 to be potential reviewers |
|
Thanks a lot for your contribution! Alternatively you can add a comment here where you state that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/ |
| return $this->file_exists($path) ? filemtime($this->getSourcePath($path)) : false; | ||
| $fullPath = $this->getSourcePath($path); | ||
| clearstatcache($fullPath); | ||
| if (!$this->file_exists($path)) { |
There was a problem hiding this comment.
This could probably be inside the 32bit block to save a bit of time
There was a problem hiding this comment.
Sorry not sure I get that, are you talking about moving file existence check inside 32bjt block?
I thought this is platform independent check which prevents us from doing any modify time work if file does not exist.
|
Any updates? |
| return false; | ||
| } | ||
| if (PHP_INT_SIZE === 4) { | ||
| return exec ('stat -c %Y '. escapeshellarg ($fullPath)); |
|
|
|
this contribution is MIT licensed |
|
👍 Looks good |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Filemtime fix for 32bit platform only.
This contribution is MIT licensed