Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a PHP Api for UserStatus #22106

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Provide a PHP Api for UserStatus #22106

merged 1 commit into from
Aug 5, 2020

Conversation

georgehrke
Copy link
Member

@georgehrke georgehrke commented Aug 4, 2020 •
edited
Loading

This PR provides a PHP API for the new User Status feature.
It allows apps to query the status for a batch of users.

@georgehrke georgehrke added the 2. developing Work in progress label Aug 4, 2020
@georgehrke
Copy link
Member Author

@nickvergessen Does this look reasonable for your use-case in Talk?

@georgehrke georgehrke mentioned this pull request Aug 5, 2020
Closed
8 tasks
@georgehrke georgehrke mentioned this pull request Aug 5, 2020
Merged
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 5, 2020
@georgehrke
Copy link
Member Author

upon the request of @nickvergessen, i changed it from IUser to userId

@georgehrke georgehrke added this to the Nextcloud 20 milestone Aug 5, 2020
@georgehrke
Provide a PHP Api for UserStatus
0e0e0d1 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
nickvergessen
nickvergessen approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦈

@nickvergessen nickvergessen mentioned this pull request Aug 5, 2020
Merged
3 tasks
@faily-bot
Copy link

faily-bot bot commented Aug 5, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31402: failure

mysql8.0-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\ScannerTest::testReuseExisting
Failed asserting that null is of type "string".

/drone/src/tests/lib/Files/Cache/ScannerTest.php:253

MorrisJobke
MorrisJobke approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke MorrisJobke merged commit 6fbf8fc into master Aug 5, 2020
@MorrisJobke MorrisJobke deleted the feature/noid/user_status_api branch August 5, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: status
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
3 participants
@georgehrke @nickvergessen @MorrisJobke