Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump underscore from 1.12.0 to 1.12.1 #26910

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 6, 2021

Bumps underscore from 1.12.0 to 1.12.1. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Arbitrary Code Execution in underscore The package underscore from 1.13.0-0 and before 1.13.0-2, from 1.3.2 and before 1.12.1 are vulnerable to Arbitrary Code Execution via the template function, particularly when a variable property is passed as an argument as it is not sanitized.

Affected versions: >= 1.3.2 < 1.12.1

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-bot.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Copy link
Member

@nextcloud-bot nextcloud-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@rullzer
Copy link
Member

rullzer commented May 10, 2021

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the dependabot/npm_and_yarn/stable21/underscore-1.12.1 branch from 2b37502 to 7926809 Compare May 10, 2021 07:42
@rullzer
Copy link
Member

rullzer commented May 11, 2021

@dependabot-bot rebase

@dependabot-preview
Copy link
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@rullzer
Copy link
Member

rullzer commented May 11, 2021

@dependabot-bot recreate

Bumps [underscore](https://github.com/jashkenas/underscore) from 1.12.0 to 1.12.1. **This update includes a security fix.**
- [Release notes](https://github.com/jashkenas/underscore/releases)
- [Commits](jashkenas/underscore@1.12.0...1.12.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/stable21/underscore-1.12.1 branch from 7926809 to e94ab3e Compare May 11, 2021 08:46
Copy link
Member

@nextcloud-bot nextcloud-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@MichaIng
Copy link
Member

MichaIng commented Jun 8, 2021

@dependabot rebase

@dependabot-preview
Copy link
Contributor Author

This repository is now using a version: 2 config so Dependabot Preview can no longer make changes to this pull request. You can close it and let Dependabot re-create it the next time it checks for updates.

@MichaIng
Copy link
Member

MichaIng commented Jun 8, 2021

@dependabot recreate

@dependabot-preview
Copy link
Contributor Author

This repository is now using a version: 2 config so Dependabot Preview can no longer make changes to this pull request. You can close it and let Dependabot re-create it the next time it checks for updates.

@MichaIng
Copy link
Member

MichaIng commented Jun 8, 2021

Shall we close all PRs opened by dependabot-preview? I wonder why it still opens PRs (#27416) when it cannot manage them anymore, and it seems to block dependabot (no-preview) with this? I guess someone needs to disable the app 😄.

@juliusknorr
Copy link
Member

It seems there was an issue when the automated PR for migrating to the new dependabot config was not merged, I've tried to retrigger that by #26819 so let's see if that helps. Let me close that one then to see if the automatic recreation with the new dependabot works.

@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/stable21/underscore-1.12.1 branch June 23, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants