Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vue and vue-template-compiler #27416

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 7, 2021

Bumps vue and vue-template-compiler. These dependencies needed to be updated together.
Updates vue from 2.6.12 to 2.6.14

Release notes

Sourced from vue's releases.

v2.6.14

Bug Fixes

  • types: async Component types (#11906) c52427b, closes #11990
  • v-slot: fix scoped slot normalization combined with v-if (#12104) 38f71de, closes #12102

Features

  • ssr: vue-ssr-webpack-plugin compatible with webpack 5 (#12002) 80e7730, closes #11718

v2.6.13

Bug Fixes

  • attrs: do not consider translate attribute as boolean (#11392) cd57393, closes #11392 #11391
  • compiler: Allow BigInt usage in templates (#11152) c42b706, closes #11152
  • compiler: avoid converting &nbps; to spaces (#11065) 55a30cf, closes #11065
  • compiler: event handlers with modifiers swallowing arguments (fix #10867) (#10958) 8620706, closes #10867 #10958
  • core: fix sameVnode for async component (#11107) 5260830, closes #11107
  • core: remove trailing comma in function signature (#10845) 579e1ff, closes #10845 #10843
  • errorHandler: async error handling for watchers (#9484) e4dea59, closes #9484
  • keep-alive: cache what is really needed not the whole VNode data (#12015) e7baaa1, closes #12015
  • parser: allow multiple slots with new syntax (#9785) 67825c2, closes #9785 #9781
  • props: correctly warn when a provided prop is Symbol (#10529) abb5ef3, closes #10529 #10519
  • props: support BigInt in props type validation (#11191) fa1f81e, closes #11191
  • slot: add a function to return the slot fallback content (#12014) ce457f9, closes #12014
  • ssr: avoid missing files in manifest (#11609) b97606c, closes #11609
  • ssr: inheritAttrs false adds attributes to html (#11706) 7e5dc6b, closes #11706
  • ssr: textarea keeps undefined/null values (#11121) b8bd149, closes #11121
  • types: add types for Vue.util.warn function (#11964) e0274e4, closes #11964 /github.com/vuejs/vue/blob/v2.6.12/src/core/util/debug.js#L18-L26
  • types: allow string for watch handlers in options (#10396) 668e1e6, closes #10396
  • types: allow symbol & boolean for vnode key (#11914) 5c459f0, closes #11914
  • types: changed expression type to optional string (#11189) 7c75462, closes #11189 #10871
  • types: make $refs undefined possible (#11112) 2b93e86, closes #11112
  • v-on: avoid events with empty keyCode (autocomplete) (#11326) c6d7a6f, closes #11326
  • force update between two components with and without slot (#11795) 77b5330, closes #11795
  • give correct namespace in foreignObject (#11576) af5e05d, closes #11576 #11575
  • handle async placeholders in normalizeScopedSlot (#11963) af54514, closes #11963
  • warns: modify maybeComponent function in parser (#10167) 0603ff6, closes #10167 #10152
  • pause dep collection during immediate watcher invocation (#11943) 987f322, closes #11943
  • v-pre: do not alter attributes (#10088) 0664cb0, closes #10088 #10087
  • vdom: avoid executing root level script tags (#11487) fb16d7b, closes #11487 #11483
  • warn: better message with no constructors props (#9241) 6940131, closes #9241

Features

... (truncated)

Commits
  • 612fb89 build: release 2.6.14
  • 8f6c4c3 build: build 2.6.14
  • c52427b fix(types): async Component types (#11906)
  • 80e7730 feat(ssr): vue-ssr-webpack-plugin compatible with webpack 5 (#12002)
  • 38f71de fix(v-slot): fix scoped slot normalization combined with v-if (#12104)
  • 67901e7 test(ssr): add missing test for async component in slot
  • 1866033 build: release 2.6.13
  • f34f6bb build: build 2.6.13
  • f038000 refactor: check is function for fallback slots
  • d6ac00f chore: display more oc sponsors on readme [ci skip]
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by posva, a new releaser for vue since your current version.


Updates vue-template-compiler from 2.6.12 to 2.6.14

Release notes

Sourced from vue-template-compiler's releases.

v2.6.14

Bug Fixes

  • types: async Component types (#11906) c52427b, closes #11990
  • v-slot: fix scoped slot normalization combined with v-if (#12104) 38f71de, closes #12102

Features

  • ssr: vue-ssr-webpack-plugin compatible with webpack 5 (#12002) 80e7730, closes #11718

v2.6.13

Bug Fixes

  • attrs: do not consider translate attribute as boolean (#11392) cd57393, closes #11392 #11391
  • compiler: Allow BigInt usage in templates (#11152) c42b706, closes #11152
  • compiler: avoid converting &nbps; to spaces (#11065) 55a30cf, closes #11065
  • compiler: event handlers with modifiers swallowing arguments (fix #10867) (#10958) 8620706, closes #10867 #10958
  • core: fix sameVnode for async component (#11107) 5260830, closes #11107
  • core: remove trailing comma in function signature (#10845) 579e1ff, closes #10845 #10843
  • errorHandler: async error handling for watchers (#9484) e4dea59, closes #9484
  • keep-alive: cache what is really needed not the whole VNode data (#12015) e7baaa1, closes #12015
  • parser: allow multiple slots with new syntax (#9785) 67825c2, closes #9785 #9781
  • props: correctly warn when a provided prop is Symbol (#10529) abb5ef3, closes #10529 #10519
  • props: support BigInt in props type validation (#11191) fa1f81e, closes #11191
  • slot: add a function to return the slot fallback content (#12014) ce457f9, closes #12014
  • ssr: avoid missing files in manifest (#11609) b97606c, closes #11609
  • ssr: inheritAttrs false adds attributes to html (#11706) 7e5dc6b, closes #11706
  • ssr: textarea keeps undefined/null values (#11121) b8bd149, closes #11121
  • types: add types for Vue.util.warn function (#11964) e0274e4, closes #11964 /github.com/vuejs/vue/blob/v2.6.12/src/core/util/debug.js#L18-L26
  • types: allow string for watch handlers in options (#10396) 668e1e6, closes #10396
  • types: allow symbol & boolean for vnode key (#11914) 5c459f0, closes #11914
  • types: changed expression type to optional string (#11189) 7c75462, closes #11189 #10871
  • types: make $refs undefined possible (#11112) 2b93e86, closes #11112
  • v-on: avoid events with empty keyCode (autocomplete) (#11326) c6d7a6f, closes #11326
  • force update between two components with and without slot (#11795) 77b5330, closes #11795
  • give correct namespace in foreignObject (#11576) af5e05d, closes #11576 #11575
  • handle async placeholders in normalizeScopedSlot (#11963) af54514, closes #11963
  • warns: modify maybeComponent function in parser (#10167) 0603ff6, closes #10167 #10152
  • pause dep collection during immediate watcher invocation (#11943) 987f322, closes #11943
  • v-pre: do not alter attributes (#10088) 0664cb0, closes #10088 #10087
  • vdom: avoid executing root level script tags (#11487) fb16d7b, closes #11487 #11483
  • warn: better message with no constructors props (#9241) 6940131, closes #9241

Features

... (truncated)

Commits
  • 612fb89 build: release 2.6.14
  • 8f6c4c3 build: build 2.6.14
  • c52427b fix(types): async Component types (#11906)
  • 80e7730 feat(ssr): vue-ssr-webpack-plugin compatible with webpack 5 (#12002)
  • 38f71de fix(v-slot): fix scoped slot normalization combined with v-if (#12104)
  • 67901e7 test(ssr): add missing test for async component in slot
  • 1866033 build: release 2.6.13
  • f34f6bb build: build 2.6.13
  • f038000 refactor: check is function for fallback slots
  • d6ac00f chore: display more oc sponsors on readme [ci skip]
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by posva, a new releaser for vue-template-compiler since your current version.


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .github/dependabot.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch from a2f2e3e to 6a4fcff Compare June 7, 2021 23:10
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch from 6a4fcff to 10bddec Compare June 8, 2021 22:57
@nextcloud nextcloud deleted a comment from dependabot-preview bot Jun 9, 2021
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch from 10bddec to 3b4ae81 Compare June 12, 2021 02:35
@blizzz blizzz mentioned this pull request Jun 16, 2021
45 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 Jun 16, 2021
@MichaIng
Copy link
Member

MichaIng commented Jul 6, 2021

Closing as of:

If you close this pull request, Dependabot will re-create it the next time it checks for updates and everything will work as expected.

@MichaIng MichaIng closed this Jul 6, 2021
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch July 6, 2021 17:33
@MichaIng MichaIng restored the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch July 15, 2021 12:56
@MichaIng MichaIng reopened this Jul 15, 2021
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch from 3b4ae81 to 988f617 Compare July 15, 2021 12:58
@MichaIng
Copy link
Member

MichaIng commented Jul 15, 2021

Looks like the statement I quoted from dependabot-preview OP is false, as the non-preview dependabot never re-created this bump for master branch 🤔.

@juliusknorr
Copy link
Member

It only runs once a week and we have a pull request limit of 10 per branch for dependabot which was hit on the last run, so i guess its just a matter of time ;)

@MichaIng
Copy link
Member

Ah okay. However, probably we won't need a new PR. Just not sure why drone is waiting for status? Is/was its queue too long?

@juliusknorr
Copy link
Member

Hard to tell, but should be retriggerd anyways with the rebase and after commiting the updated bundles

@skjnldsv
Copy link
Member

@dependabot rebase

@dependabot-preview
Copy link
Contributor Author

This repository is now using a version: 2 config so Dependabot Preview can no longer make changes to this pull request. You can close it and let Dependabot re-create it the next time it checks for updates.

@skjnldsv skjnldsv closed this Jul 16, 2021
@skjnldsv skjnldsv deleted the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch July 16, 2021 07:48
@MichaIng
Copy link
Member

MichaIng commented Jul 16, 2021

I checked a few other closed dependabot-preview PRs, and they were all not opened again. Good that the regular GitHub actions bot can rebase as well (/rebase) 🙂.

@MichaIng MichaIng restored the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch July 16, 2021 09:08
@MichaIng MichaIng reopened this Jul 16, 2021
@MichaIng
Copy link
Member

MichaIng commented Jul 16, 2021

/compile amend /

EDIT: But bad that the compiling bot is still down 🙁.

Bumps [vue](https://github.com/vuejs/vue) and [vue-template-compiler](https://github.com/vuejs/vue). These dependencies needed to be updated together.

Updates `vue` from 2.6.12 to 2.6.14
- [Release notes](https://github.com/vuejs/vue/releases)
- [Commits](vuejs/vue@v2.6.12...v2.6.14)

Updates `vue-template-compiler` from 2.6.12 to 2.6.14
- [Release notes](https://github.com/vuejs/vue/releases)
- [Commits](vuejs/vue@v2.6.12...v2.6.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch from 988f617 to 5e4a349 Compare July 16, 2021 09:09
@skjnldsv
Copy link
Member

@MichaIng let's close and let dependabot open it again on their new workflow.

@skjnldsv skjnldsv closed this Jul 16, 2021
@skjnldsv skjnldsv deleted the dependabot/npm_and_yarn/vue-and-vue-template-compiler-2.6.14 branch July 16, 2021 09:39
@MichaIng
Copy link
Member

We tried that already, and it did not re-open it for more than 9 days, same with all other closed preview dependabot PRs 🤔. The only thing that is missing here is compiling and amending scripts, so we don't need the dependabot for it, but only the compile bot.

But I guess with next vue release, new PRs will be opened.

@juliusknorr
Copy link
Member

But I guess with next vue release, new PRs will be opened.

Or on saturday as this is when the next run is #27416 (comment) and we now have capacity since the master pr count of dependabot is < 10

@MichaIng
Copy link
Member

MichaIng commented Jul 16, 2021

Let's see. For "marked" it seems as well that dependabot is not checking for releases and ignoring commands on #27228, after a preview-dependabot PR #26414 has been closed: https://github.com/nextcloud/server/pulls?q=is%3Apr+bump+marked+base%3Astable21+

Or more precisely, it did not open a PR to bump "marked" to 2.0.0 anymore, but instead (after that was closed) to the lower version 1.2.9. I just wonder why it didn't track the newer releases (for stable21) which are available already: #27393 (same here, closed 24 days ago, no new PR since then)

@MichaIng
Copy link
Member

MichaIng commented Jul 17, 2021

As guessed, no new PR has been opened, same with all other closed preview dependabot PRs. To me it looks like we either need to reopen all those and rebase/compile/merge manually, or we need to reset dependabots memory. Especially problematic is this for bumps which include security patches, like for the marked module and such. EDIT: Ah it just took a few more hours, now it's there 👍: #28030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants