Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full name section Vuetified #28028

Merged
merged 6 commits into from
Aug 26, 2021
Merged

Full name section Vuetified #28028

merged 6 commits into from
Aug 26, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 17, 2021 •
edited
Loading

To Do

  • Pass initial state from server to client
  • Create service
  • Abstract shared components
  • Rewrite Email section
  • Rewrite php markup and functionality in Vue apps/settings/templates/settings/personal/persona.info.php
  • Rewrite with functional paradigm
  • Refine input validation

Note: The TODO comments are out-of-scope for this PR and will be addressed separately in future PRs

Contributes to #27869

@Pytal Pytal added enhancement 2. developing Work in progress labels Jul 17, 2021
@Pytal Pytal added this to the Nextcloud 23 milestone Jul 17, 2021
@Pytal Pytal self-assigned this Jul 17, 2021
@Pytal Pytal mentioned this pull request Jul 17, 2021
Closed
11 tasks
@Pytal Pytal force-pushed the feat/27869/full-name branch 2 times, most recently from e40dd2e to 954099c Compare July 22, 2021 00:14
@Pytal Pytal marked this pull request as ready for review July 22, 2021 00:17
@Pytal Pytal added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Jul 22, 2021
@Pytal Pytal force-pushed the feat/27869/full-name branch from 954099c to 411f790 Compare July 23, 2021 22:27
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 23, 2021
@Pytal Pytal force-pushed the feat/27869/full-name branch from 411f790 to 6d8d279 Compare July 23, 2021 22:35
@Pytal Pytal force-pushed the feat/27869/full-name branch 2 times, most recently from 3c8fbc5 to 2740239 Compare July 29, 2021 01:44
@Pytal Pytal requested a review from artonge July 29, 2021 02:13
@Pytal Pytal force-pushed the feat/27869/full-name branch 2 times, most recently from afde20a to 171c805 Compare August 4, 2021 00:52
@Pytal Pytal force-pushed the feat/27869/full-name branch from 171c805 to a86a874 Compare August 7, 2021 02:10
@Pytal Pytal requested a review from skjnldsv August 11, 2021 02:23
@Pytal Pytal force-pushed the feat/27869/full-name branch from dd06b5f to ad38556 Compare August 16, 2021 20:26
@Pytal Pytal mentioned this pull request Aug 16, 2021
Merged
6 tasks
@nextcloud-command nextcloud-command force-pushed the feat/27869/full-name branch 2 times, most recently from 210b9c0 to f14fd02 Compare August 17, 2021 23:22
@Pytal Pytal force-pushed the feat/27869/full-name branch 2 times, most recently from ad38556 to 2949d8e Compare August 17, 2021 23:30
@skjnldsv
Copy link
Member

Good for me, other tiny comments can be addressed in follow-up :)

Pytal added 4 commits August 23, 2021 21:29
@Pytal
Provide initial state
d4d5949 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Create display name service and update constants
db182d6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Vuetify
a8ad5a3 
- abstract shared components
- rewrite email section

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Functional paradigm shift
5e67677 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/27869/full-name branch from ce0c7da to e9ccfbe Compare August 23, 2021 23:01
@Pytal
Refine input validation
d738ca4 
- Remove usage of JS core checkValidity() in favour of custom backend compliant validation
- Rewrite and refactor with removal of form tag in favour of section
- Scope styles
- Remove many uses of $nextTick
- Refine disabled state logic
- Translate account property constants

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/27869/full-name branch from a7a44fb to d738ca4 Compare August 24, 2021 23:00
@Pytal
Copy link
Member Author

Pytal commented Aug 24, 2021

/compile /

@nextcloud-command
Compile assets
c67a6e5 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr juliusknorr dismissed artonge’s stale review August 26, 2021 20:08

Seem all addressed

@juliusknorr
Copy link
Member

Let's get this in.

Nice work @Pytal :)

@juliusknorr juliusknorr merged commit 78a5768 into master Aug 26, 2021
@juliusknorr juliusknorr deleted the feat/27869/full-name branch August 26, 2021 20:09
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@julien-nc julien-nc Awaiting requested review from julien-nc

@artonge artonge Awaiting requested review from artonge

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
7 participants
@Pytal @skjnldsv @juliusknorr @nickvergessen @ChristophWurst @artonge @nextcloud-command