Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language section Vuetified #28423

Merged
merged 6 commits into from
Aug 27, 2021
Merged

Language section Vuetified #28423

merged 6 commits into from
Aug 27, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 14, 2021 •
edited
Loading

To Do

  • Pass initial state from server to client
  • Create service
  • Rewrite php markup and functionality in Vue apps/settings/templates/settings/personal/persona.info.php
  • Reload on change
  • Refine input validation
  • Rename language strings in other apps (only Talk) to camelCase

Note: The TODO comments are out-of-scope for this PR and will be addressed separately in future PRs

To be merged to master after #28028

Contributes to #27869

@Pytal Pytal added enhancement 2. developing Work in progress labels Aug 14, 2021
@Pytal Pytal added this to the Nextcloud 23 milestone Aug 14, 2021
@Pytal Pytal self-assigned this Aug 14, 2021
This was referenced Aug 14, 2021
Closed
Merged
@Pytal Pytal force-pushed the feat/27869/full-name branch from dd06b5f to ad38556 Compare August 16, 2021 20:26
@Pytal Pytal force-pushed the feat/27869/language branch from f8d3722 to 39197f7 Compare August 16, 2021 22:02
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 16, 2021
@Pytal Pytal requested a review from a team August 16, 2021 22:12
@Pytal Pytal marked this pull request as ready for review August 16, 2021 22:12
artonge
artonge approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

apps/settings/src/components/PersonalInfo/LanguageSection/Language.vue Outdated Show resolved Hide resolved
apps/settings/src/components/PersonalInfo/shared/HeaderBar.vue Outdated Show resolved Hide resolved
@Pytal Pytal force-pushed the feat/27869/language branch from 6bdd7e7 to 52ff7d0 Compare August 17, 2021 23:10
@Pytal Pytal force-pushed the feat/27869/full-name branch 2 times, most recently from ad38556 to 2949d8e Compare August 17, 2021 23:30
@Pytal Pytal force-pushed the feat/27869/language branch from 2d45856 to cfcada3 Compare August 17, 2021 23:32
artonge
artonge requested changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, misclick on approve

@Pytal Pytal force-pushed the feat/27869/language branch 2 times, most recently from f9d8230 to ddeb395 Compare August 18, 2021 21:43
@Pytal Pytal force-pushed the feat/27869/language branch from 9007681 to f6e61f6 Compare August 19, 2021 21:13
@Pytal

This comment has been minimized.

Sign in to view
@Pytal Pytal force-pushed the feat/27869/full-name branch 2 times, most recently from a7a44fb to d738ca4 Compare August 24, 2021 23:00
@Pytal Pytal force-pushed the feat/27869/language branch from fb48d6c to cdf59cb Compare August 24, 2021 23:47
@Pytal

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv requested a review from artonge August 26, 2021 16:09
Base automatically changed from feat/27869/full-name to master August 26, 2021 20:09
@Pytal

This comment has been minimized.

Sign in to view
Pytal added 5 commits August 27, 2021 05:06
@Pytal
Provide initial state
cc5815d 
- camelCase language strings

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Create language service and update constants
c659872 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Minor refactor
5494482 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Vuetify
0552b6a 
- abstract HeaderBar component

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Update option separator
3f6586b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/27869/language branch from d71e571 to 14fadca Compare August 27, 2021 05:07
@Pytal
Copy link
Member Author

Pytal commented Aug 27, 2021

/compile amend /

@Pytal @nextcloud-command
Refine input validation
f6119b7 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal merged commit 95662a1 into master Aug 27, 2021
@Pytal Pytal deleted the feat/27869/language branch August 27, 2021 05:57
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @juliusknorr @artonge @skjnldsv