Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require a recent phpunit version in integration and acceptance #31761

Merged
merged 1 commit into from
May 24, 2022
Merged

Require a recent phpunit version in integration and acceptance #31761

merged 1 commit into from
May 24, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 30, 2022

Otherwise build with PHP>8 will fail as PHPUnit 6 does not support it

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc come-nc added the 3. to review Waiting for reviews label Mar 30, 2022
@come-nc come-nc added this to the Nextcloud 24 milestone Mar 30, 2022
@come-nc come-nc self-assigned this Mar 30, 2022
@come-nc come-nc mentioned this pull request Mar 30, 2022
Merged
@come-nc come-nc requested review from a team, nickvergessen, juliusknorr, skjnldsv and CarlSchwan and removed request for a team March 30, 2022 14:16
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
danxuliu
danxuliu requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing Assert::assertContains to Assert::assertStringContainsString is also needed in some integration tests; there might be other changes needed too, but I have not checked.

This was referenced Apr 7, 2022
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@CarlSchwan CarlSchwan mentioned this pull request May 24, 2022
Merged
@danxuliu danxuliu force-pushed the fix/upgarde-phpunit-in-ci-to-recent-version branch from ea5770d to 40da863 Compare May 24, 2022 15:19
@come-nc @danxuliu
Require a recent phpunit version in integration and acceptance
8951f06 
Otherwise build with PHP>8 will fail as PHPUnit 6 does not support it

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@danxuliu danxuliu force-pushed the fix/upgarde-phpunit-in-ci-to-recent-version branch from 40da863 to 8951f06 Compare May 24, 2022 16:55
@CarlSchwan CarlSchwan requested a review from danxuliu May 24, 2022 18:45
danxuliu
danxuliu approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the remaining failures, rebased on latest master and squashed the fixups; CI is happy, so 👍

@CarlSchwan CarlSchwan merged commit eb5e0a4 into master May 24, 2022
@CarlSchwan CarlSchwan deleted the fix/upgarde-phpunit-in-ci-to-recent-version branch May 24, 2022 20:18
@come-nc come-nc mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
5 participants
@come-nc @nickvergessen @CarlSchwan @danxuliu @blizzz