Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bunch of deprecation in the phpunit for core #32572

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Fix a bunch of deprecation in the phpunit for core #32572

merged 3 commits into from
Jan 24, 2023

Conversation

CarlSchwan
Copy link
Member

No description provided.

@CarlSchwan CarlSchwan requested review from come-nc and a team May 24, 2022 11:27
@CarlSchwan CarlSchwan self-assigned this May 24, 2022
@CarlSchwan CarlSchwan requested review from PVince81 and blizzz and removed request for a team May 24, 2022 11:27
@CarlSchwan CarlSchwan mentioned this pull request May 24, 2022
Open
15 tasks
@CarlSchwan
Copy link
Member Author

Needs #31761 to kill old phpunit version

@nickvergessen
Copy link
Member

Needs a rebase?

@CarlSchwan
Copy link
Member Author

/rebase

@nextcloud-command nextcloud-command force-pushed the phpunit-deprecation-core branch from 01f156a to 1cb612a Compare May 25, 2022 07:20
@CarlSchwan
Copy link
Member Author

integration tests are still using phpunit 8 :(

@CarlSchwan CarlSchwan force-pushed the phpunit-deprecation-core branch 2 times, most recently from b2be49a to 3ba578e Compare May 30, 2022 12:53
@PVince81
Copy link
Member

there are still some test failures

@CarlSchwan
Copy link
Member Author

/rebase

@nextcloud-command nextcloud-command force-pushed the phpunit-deprecation-core branch from 3ba578e to a8aa9f9 Compare June 21, 2022 10:33
@nickvergessen
Copy link
Member

nickvergessen commented Jun 29, 2022 •
edited
Loading

There was 1 error:

  1. Tests\Core\Data\LoginFlowV2ServiceUnitTest::testFlowDone
    --
    Error: Call to undefined method Tests\Core\Data\LoginFlowV2ServiceUnitTest::assertMatchesRegularExpression()
    /drone/src/tests/Core/Service/LoginFlowV2ServiceUnitTest.php:353

CarlSchwan and others added 3 commits January 24, 2023 09:34
@CarlSchwan @come-nc
Fix a bunch of deprecation in the phpunit for core
a23cd7b 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan @come-nc
Use phpunit from composer if available
5b0f7f7 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@come-nc
Fix tests failures (number of calls differed with last rebase)
003cc2b 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the phpunit-deprecation-core branch from a8aa9f9 to 003cc2b Compare January 24, 2023 08:39
@come-nc come-nc assigned come-nc and unassigned CarlSchwan Jan 24, 2023
@come-nc come-nc added the 2. developing Work in progress label Jan 24, 2023
@come-nc come-nc added this to the Nextcloud 26 milestone Jan 24, 2023
@come-nc come-nc merged commit 486e1df into master Jan 24, 2023
@come-nc come-nc deleted the phpunit-deprecation-core branch January 24, 2023 10:28
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish technical debt and removed 2. developing Work in progress do not merge labels Jan 24, 2023
@nickvergessen nickvergessen mentioned this pull request Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@blizzz blizzz blizzz approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@come-nc come-nc

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@CarlSchwan @nickvergessen @PVince81 @blizzz @come-nc