[LDAP] always create instance of own user manager

[blizzz]

• it is config specific and cannot be shared
• because the Access instance is bound later, it is not obvious from the constructor

fixes #34993

[blizzz]

/backport to stable25

[blizzz]

/backport to stable24

[szaimen]

🐘

[szaimen]

Merge or do we wanna wait for the feedback?

[blizzz]

Merge or do we wanna wait for the feedback?

Let's see tomorrow.

[michel-nicol]

I tested this patch on the third Nextcloud server I'm administering, which I kept back at 24.0.6. I upgraded to 24.0.7 using the updater and then replaced Application.php with the proposed version, and all worked flawlessly.

[szaimen]

Great! Thanks for veryfying :)

[aknauss]

Hi,
It seems that bug with two ldap is here on Nextcloud 26...
How can I do to patch this version?

Thanks a lot.
Franck

[chritd]

same problem after upgrading to 26.
is there already a fix?
many thx

[szaimen]

Should be fixed with 26.0.2

[florian-obradovic]

Fix with the current commit:

Backup

cd /var/www/nextcloud/apps

cp -rfv user_ldap ~/user_ldap-BACKUP

cd /var/www/nextcloud/apps/user_ldap/lib

sudo rm AccessFactory.php

sudo wget https://raw.githubusercontent.com/nextcloud/server/967955358c2693aafb1e43795b09cf24e460929b/apps/user_ldap/lib/AccessFactory.php

sudo rm Sync.php

sudo wget https://raw.githubusercontent.com/nextcloud/server/967955358c2693aafb1e43795b09cf24e460929b/apps/user_ldap/lib/Jobs/Sync.php

sudo wget https://raw.githubusercontent.com/nextcloud/server/967955358c2693aafb1e43795b09cf24e460929b/apps/user_ldap/tests/Jobs/SyncTest.php