Fix multiple LDAP configuration support by fixing AccessFactory #37903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It must not reuse the same OCA\User_LDAP\User\Manager instance for several Access instances. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
/backport to stable26 |
come-nc
requested review from
a team,
ArtificialOwl and
icewind1991
and removed request for
a team
blizzz
approved these changes
Apr 24, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
Tested this patch, it solves the issue on NC 26 |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
artonge
approved these changes
Apr 27, 2023
| @@ -55,7 +53,7 @@ public function get(Connection $connection): Access { | |||
| return new Access( | |||
| $connection, | |||
| $this->ldap, | |||
| $this->userManager, | |||
| Server::get(Manager::class), | |||
There was a problem hiding this comment.
Can you add a comment to explain why we do not use DI? It will help to not revert in the future.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
added
4. to release
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #34772 broke the fix from PR #35070 because AccessFactory was reusing the same Manager instance for all access instances.
Checklist