Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve email results for sharing #35097

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Improve email results for sharing #35097

merged 2 commits into from
Dec 9, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 11, 2022 •
edited
Loading

Steps

  1. Search for Foo Bar <foo.bar@example.tld> in the share sidebar
  2. See a broken entry
Before 💥 invalid remote share After ✨ working email share
< in user id is invalid
> in server part is invalid		 ✅
Bildschirmfoto vom 2022-11-11 09-49-34 Bildschirmfoto vom 2022-11-11 09-49-24
Bildschirmfoto vom 2022-11-11 09-49-45 Bildschirmfoto vom 2022-11-11 09-49-02

@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Nov 11, 2022
@nickvergessen nickvergessen requested review from blizzz, artonge, skjnldsv, a team and juliusknorr and removed request for a team November 11, 2022 08:52
@nickvergessen
Copy link
Member Author

/backport to stable25

@nickvergessen
Copy link
Member Author

/backport to stable24

@blizzz
Copy link
Member

blizzz commented Nov 14, 2022 

There was 1 failure:

1) Test\User\DatabaseTest::testSearch

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125

I don't think it's related (also only pgsql 13 failing), but restarting ci in case. Everything else is green.

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 14, 2022
@szaimen
Copy link
Contributor

szaimen commented Dec 3, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the bugfix/noid/improve-email-results branch from a005273 to 85ae0c7 Compare December 3, 2022 18:13
@szaimen szaimen enabled auto-merge December 3, 2022 19:30
@nickvergessen
Validate if the user part of a "cloud id" can even be a valid user id
256fbe9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Improve email search results
269df90 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-email-results branch from 85ae0c7 to 269df90 Compare December 9, 2022 21:41
@szaimen szaimen merged commit 51f8b9c into master Dec 9, 2022
@szaimen szaimen deleted the bugfix/noid/improve-email-results branch December 9, 2022 22:45
This was referenced Dec 9, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@blizzz blizzz blizzz approved these changes

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @blizzz @szaimen @juliusknorr