-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable24] Improve email results for sharing #35713
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Linter is unsatisfied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not there yet
* @param string $uid | ||
* @param bool $checkDataDirectory | ||
* @throws \InvalidArgumentException Message is an already translated string with a reason why the id is not valid | ||
* @since 26.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24.0.whateveritwillbe
* @param string $uid The user ID to validate | ||
* @param bool $checkDataDirectory Whether it should be checked if files for the ID exist inside the data directory | ||
* @throws \InvalidArgumentException Message is an already translated string with a reason why the ID is not valid | ||
* @since 26.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24.0.whateveritwillbe
moving to 24.0.11 |
moving to 24.0.12 |
Shall we close this since 24 is EOL? |
@nickvergessen for there is no traction since Dec is suppose there is no need more to have it in 24. Otherwise, please reopen and address reviews pls. |
backport of #35097