Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Improve email results for sharing #35713

Closed
wants to merge 3 commits into from

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #35097

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
skjnldsv

This comment was marked as resolved.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Dec 12, 2022
@blizzz blizzz mentioned this pull request Feb 6, 2023
@blizzz
Copy link
Member

blizzz commented Feb 7, 2023

Linter is unsatisfied

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not there yet

* @param string $uid
* @param bool $checkDataDirectory
* @throws \InvalidArgumentException Message is an already translated string with a reason why the id is not valid
* @since 26.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.0.whateveritwillbe

* @param string $uid The user ID to validate
* @param bool $checkDataDirectory Whether it should be checked if files for the ID exist inside the data directory
* @throws \InvalidArgumentException Message is an already translated string with a reason why the ID is not valid
* @since 26.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.0.whateveritwillbe

@blizzz
Copy link
Member

blizzz commented Feb 9, 2023

moving to 24.0.11

@blizzz
Copy link
Member

blizzz commented Mar 16, 2023

moving to 24.0.12

This was referenced Apr 13, 2023
@skjnldsv skjnldsv removed this from the Nextcloud 24.0.12 milestone Apr 18, 2023
@skjnldsv skjnldsv added this to the Nextcloud 24.0.13 milestone Apr 18, 2023
@juliusknorr
Copy link
Member

Shall we close this since 24 is EOL?

@blizzz
Copy link
Member

blizzz commented Jun 20, 2023

Shall we close this since 24 is EOL?

@nickvergessen for there is no traction since Dec is suppose there is no need more to have it in 24. Otherwise, please reopen and address reviews pls.

@blizzz blizzz closed this Jun 20, 2023
@nickvergessen nickvergessen deleted the backport/35097/stable24 branch June 21, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants