Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SabrePublicPluginEvent to BeforeSabrePubliclyLoadedEvent #35789

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

julien-nc
Copy link
Member

And run build/autoloaderchecker.sh

refs #35621 #35784

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New file missing?

@julien-nc julien-nc force-pushed the fix/noid/rename-sabre-public-event branch from f13629c to 142700d Compare December 15, 2022 16:33
…build/autoloaderchecker.sh

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the fix/noid/rename-sabre-public-event branch from 142700d to 73f2876 Compare December 15, 2022 16:37
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Dec 15, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 8a0add4 into master Dec 16, 2022
@PVince81 PVince81 deleted the fix/noid/rename-sabre-public-event branch December 16, 2022 10:40
julien-nc added a commit that referenced this pull request Dec 19, 2022
… allow adding additional Sabre plugins in publicwebdav.php

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc added a commit that referenced this pull request Dec 19, 2022
… allow adding additional Sabre plugins in publicwebdav.php

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc added a commit that referenced this pull request Dec 19, 2022
… allow adding additional Sabre plugins in publicwebdav.php

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc added a commit that referenced this pull request Jan 3, 2023
… allow adding additional Sabre plugins in publicwebdav.php

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc added a commit that referenced this pull request Jan 3, 2023
… allow adding additional Sabre plugins in publicwebdav.php

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@nickvergessen
Copy link
Member

Please document in #34692

@julien-nc
Copy link
Member Author

Please document in #34692

👍 Done

@DaphneMuller
Copy link

hello @julien-nc
Thank you so much for your work on this pull request! This ticket seems to have the tag 'pending documentation'.
Is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

@DaphneMuller
Copy link

Hello!
Thank you for your work on this! I noticed that your PR still has the label 'documentation'. I'm not sure if you already had a look at the documentation for your PR, but at Nextcloud we strive to document changes that affect other app developers or other admins before the release takes place, and I'm pinging you with the hope to get this done.

Are you familiar with our documentation process already?
Changes that affect app developers should be documented here:
https://docs.nextcloud.com/server/27/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html

Changes that affect administrators should be documented here:
https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html

While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here:
https://docs.nextcloud.com/server/27/developer_manual/prologue/compatibility_app_ecosystem.html#documentation-procedures-of-changes-that-affect-app-developers

If all your documentation efforts are done, please remove the label 'pending documentation' and check the checkbox in your opening note and I'll stop bugging you :)

Many thanks in advance and thanks again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug feature: dav pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants