Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Allow additional Sabre plugins in publicwebdav.php #35817

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Dec 19, 2022

Dispatch new BeforeSabrePubliclyLoadedEvent to allow adding additional Sabre plugins in publicwebdav.php.

Manual backport of #35621 and #35789

@julien-nc julien-nc added this to the Nextcloud 25.0.3 milestone Dec 19, 2022
@julien-nc julien-nc changed the title Manual backport of #35789 [stable25] Manual backport of #35789 Dec 19, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristophWurst ChristophWurst changed the title [stable25] Manual backport of #35789 [stable25] Allow additional Sabre plugins in publicwebdav.php Dec 20, 2022
… allow adding additional Sabre plugins in publicwebdav.php

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the backport/35789/stable25 branch from 48adb59 to fb9dfb6 Compare January 3, 2023 09:15
@PVince81 PVince81 requested a review from come-nc January 4, 2023 09:23
@PVince81 PVince81 merged commit c255735 into stable25 Jan 5, 2023
@PVince81 PVince81 deleted the backport/35789/stable25 branch January 5, 2023 08:43
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
6 tasks
* Dispatched before Sabre is loaded when accessing public webdav endpoints
* This can be used to inject a Sabre plugin for example
*
* @since 25.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More like

Suggested change
* @since 25.0.0
* @since 25.0.3

But too late now I guess.

And also this should be mentioned in #32117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants