-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directly fix invalid values of DTEND and DTSTART #4066
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer to be a potential reviewer. |
Codecov Report
@@ Coverage Diff @@
## master #4066 +/- ##
============================================
- Coverage 54.24% 54.22% -0.02%
+ Complexity 21285 21283 -2
============================================
Files 1310 1309 -1
Lines 81187 81198 +11
Branches 1284 1284
============================================
- Hits 44036 44030 -6
- Misses 37151 37168 +17
Continue to review full report at Codecov.
|
@nickvergessen So this is intended to be run on every upgrade? Otherwise add a version number check. |
Basically yes. It only does stuff for broken entries anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. And fixed some broken stuff I threw at it.
So lets do it...
Ref #4014
Fix #2741
Fix #3350
Fix #3734
@georgehrke @rullzer