[stable11] Directly fix invalid values of DTEND and DTSTART

[nickvergessen]

Backport #4066

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke and @rullzer to be potential reviewers.

[rullzer]

nice. Worked here... lets see if it works for everybody...

[MorrisJobke]

Tested and works - at least for my calendar

[toeff]

Updated from 11.0.2.7 to 11.0.3.2
Sadly doesn't work with one of my calendars. Still getting an "Internal Server Error" when exporting. Logfile says: "Fatal webdav Sabre\VObject\InvalidDataException: Unsupported VALUE parameter for DTEND property. You supplied """

[nickvergessen]

@rullzer empty DTEND?! Ever heard of that?

[rullzer]

Nope 😕
Maybe there was nothing supplied at all?

[toeff]

I have solved my problem through an export via thunderbird and then re-import as a new calendar.

[PiQuer]

Just a heads up if someone still gets the internal server error: check your database for DTEND;VALUE=;. I had 8 year old entries of the form

DTEND;VALUE=;TZID=Europe/Vienna:20110330T120000

with no idea where they came from. They could be fixed by replacing ; for : in the following lines of apps/dav/lib/Migration/CalDAVRemoveEmptyValue.php:

line 61:
$pattern = ';VALUE=:';
change to
$pattern = ';VALUE=;';
line 69:
$data = preg_replace('/' . $pattern . '/', ':', $calObject['calendardata']);
change to
$data = preg_replace('/' . $pattern . '/', ';', $calObject['calendardata']);

Then run occ maintenance:repair. Maybe the script could look for both patterns?