Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): hide search provider from list #41646

Merged
merged 2 commits into from
Nov 22, 2023
Merged

feat(search): hide search provider from list #41646

merged 2 commits into from
Nov 22, 2023

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Nov 21, 2023 •
edited
Loading

@Altahrim Altahrim added the 3. to review Waiting for reviews label Nov 21, 2023
@Altahrim Altahrim requested review from nickvergessen and a team November 21, 2023 17:17
@Altahrim Altahrim self-assigned this Nov 21, 2023
@Altahrim Altahrim requested review from ArtificialOwl, nfebe and sorbaugh and removed request for a team November 21, 2023 17:17
@Altahrim Altahrim mentioned this pull request Nov 21, 2023
Closed
nfebe
nfebe approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one in-line worry, this works.

nickvergessen
nickvergessen reviewed Nov 21, 2023
View reviewed changes
lib/public/Search/IProvider.php Outdated Show resolved Hide resolved
lib/public/Search/IProvider.php Show resolved Hide resolved
@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@Altahrim Altahrim force-pushed the feat/hide-search-provider branch from e328a87 to bf3a68f Compare November 22, 2023 07:35
@Altahrim
feat(search): hide search provider
75e5854 
Some search providers can be hidden if they send `null` in `getOrder`

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
feat(search): hide user search if not on user list
0d8aa68 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the feat/hide-search-provider branch from bf3a68f to 0d8aa68 Compare November 22, 2023 07:48
@Altahrim Altahrim enabled auto-merge November 22, 2023 07:49
@Altahrim Altahrim merged commit ba1af2b into master Nov 22, 2023
50 checks passed
@Altahrim Altahrim deleted the feat/hide-search-provider branch November 22, 2023 08:49
@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Nov 30, 2023
@nickvergessen
fix(search): Hide "Messages in current conversation" when not on talk
f2fddb6 
Possible since nextcloud/server#41646

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Nov 30, 2023
Merged
3 tasks
backportbot-nextcloud bot pushed a commit to nextcloud/spreed that referenced this pull request Nov 30, 2023
@nickvergessen @backportbot-nextcloud
fix(search): Hide "Messages in current conversation" when not on talk
75eab61 
Possible since nextcloud/server#41646

Signed-off-by: Joas Schilling <coding@schilljs.com>
@joshtrichards joshtrichards mentioned this pull request Jul 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@nfebe nfebe nfebe approved these changes

@artonge artonge artonge approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@Altahrim @nickvergessen @artonge @nfebe @solracsf