Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updates for global search #41781

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Nov 27, 2023

  • Use standard font of filter tags/chips
  • No bold
  • Use close icon and no close thick

#41651

@Fenn-CS Fenn-CS changed the title Improve accesibility for search tags/chips UI updates for global search Nov 27, 2023
@Fenn-CS Fenn-CS force-pushed the minor-ui-updates-global-search branch from 1f27342 to d886b51 Compare November 27, 2023 22:40
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Nov 27, 2023

Before After
Screenshot from 2023-11-27 23-46-54 Screenshot from 2023-11-27 23-44-55
Screenshot from 2023-11-27 23-47-16 Screenshot from 2023-11-27 23-45-09

@nimishavijay

@Fenn-CS Fenn-CS force-pushed the minor-ui-updates-global-search branch from d886b51 to 2199f82 Compare November 28, 2023 14:27
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Nov 28, 2023

/compile amend /

@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Nov 28, 2023
@Fenn-CS Fenn-CS force-pushed the minor-ui-updates-global-search branch 2 times, most recently from 743d76a to 4944c60 Compare November 28, 2023 16:08
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Nov 28, 2023

/compile amend /

@AndyScherzinger AndyScherzinger mentioned this pull request Nov 29, 2023
3 tasks
- Use stand font of filter tags/chips
- No bold
- Use close icon and no close thick

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@AndyScherzinger AndyScherzinger force-pushed the minor-ui-updates-global-search branch 2 times, most recently from fc2cdfb to d972e16 Compare November 29, 2023 10:45
@AndyScherzinger
Copy link
Member

/compile amend /

1 similar comment
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Nov 29, 2023

/compile amend /

- Show loading when actually loading, instead of no content
- Change modified label to `Date` as it applies to a bunch of things.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit 8f7a138 into master Nov 29, 2023
40 of 41 checks passed
@AndyScherzinger AndyScherzinger deleted the minor-ui-updates-global-search branch November 29, 2023 14:08
@AndyScherzinger
Copy link
Member

/backport to stable28

@blizzz
Copy link
Member

blizzz commented Nov 29, 2023

/backport to stable28

@blizzz
Copy link
Member

blizzz commented Nov 29, 2023

likely will not backport because of the compiled assets. if they were in a separate commit, only those can be picked with the source changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants