Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left over polishing for global search from #41651

Closed
9 of 10 tasks
Fenn-CS opened this issue Nov 21, 2023 · 1 comment · Fixed by #41652
Closed
9 of 10 tasks

Left over polishing for global search from #41651

Fenn-CS opened this issue Nov 21, 2023 · 1 comment · Fixed by #41652
Assignees
@Fenn-CS
Labels
enhancement feature: search ❄️ 2023-Winter
Milestone
Nextcloud 28

Comments

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Nov 21, 2023 •
edited
Loading

Left over polishing for global search from #41507

TODO

High

  • Search field is not focused automatically when the modal is opened

Medium

  • Contacts filter shouldn’t be available if contacts app is not available
  • No space for icons in modified (Fenn-CS : Best handled at component level, migrate to vue lib repo? "Do not reserve space for icon in NcActionButton if no icon is provided"???)
  • Use user bubble component for small chips (Copied accessibility styles from nc user bubble)
  • Close after click set to true on actions component for date range component (Not reproducible, and never encountered)

Low

  • "No matching results" emptycontent icon should be a search icon instead of the current one
  • Text in People" menu regular not bold
  • Close icon material design icon "close" instead of "close-thick"
  • "Apps and settings" icon should be smaller and have more margin on left and right (similar to action menu in files, for eg)
  • "No matching results" is shown even when loading, instead show "Searching for results..."
@Fenn-CS Fenn-CS added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 21, 2023
@Fenn-CS Fenn-CS self-assigned this Nov 21, 2023
@Fenn-CS Fenn-CS added enhancement feature: search and removed bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 21, 2023
Fenn-CS added a commit that referenced this issue Nov 21, 2023
@Fenn-CS
Focus global search input on open
097219b 
For better accesibility, the search input in the global search
modal should be focused when the search modal is opened.

Resolves: #41651

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS mentioned this issue Nov 21, 2023
Merged
@solracsf solracsf changed the title [Bug]: Left over polishing for global search from Nov 21, 2023
Fenn-CS added a commit that referenced this issue Nov 23, 2023
@Fenn-CS
Focus global search input on open
32230cc 
For better accesibility, the search input in the global search
modal should be focused when the search modal is opened.

Resolves: #41651

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit that referenced this issue Nov 23, 2023
@Fenn-CS
Focus global search input on open
55830a4 
For better accesibility, the search input in the global search
modal should be focused when the search modal is opened.

Resolves: #41651

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nextcloud-command pushed a commit that referenced this issue Nov 23, 2023
@Fenn-CS @nextcloud-command
Focus global search input on open
8c6c0d1 
For better accesibility, the search input in the global search
modal should be focused when the search modal is opened.

Resolves: #41651

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 23, 2023
@Fenn-CS @backportbot-nextcloud
Focus global search input on open
ef73f18 
For better accesibility, the search input in the global search
modal should be focused when the search modal is opened.

Resolves: #41651

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Nov 23, 2023
@Fenn-CS Fenn-CS reopened this Nov 24, 2023
@Fenn-CS Fenn-CS mentioned this issue Nov 27, 2023
Merged
@Fenn-CS Fenn-CS mentioned this issue Dec 8, 2023
Open
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 8, 2023

Closing this since only item left is now tracked in : nextcloud-libraries/nextcloud-vue#4939

@Fenn-CS Fenn-CS closed this as completed Dec 8, 2023
zak39 pushed a commit to zak39/server that referenced this issue Dec 19, 2023
@Fenn-CS @zak39
Focus global search input on open
6244d8f 
For better accesibility, the search input in the global search
modal should be focused when the search modal is opened.

Resolves: nextcloud#41651

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fenn-CS Fenn-CS

Labels
enhancement feature: search ❄️ 2023-Winter
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging a pull request may close this issue.

Focus global search input on open nextcloud/server
3 participants
@AndyScherzinger @susnux @Fenn-CS