Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements: Fix and updates to most recent global search UI #41507

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Enhancements: Fix and updates to most recent global search UI #41507

merged 3 commits into from
Nov 21, 2023

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 15, 2023 •
edited by Altahrim
Loading

  • Allow future dates in custom date range
  • Fix date ranges for example, before now, today range was roughly between now() to now() + a few milli seconds

Resolves : #41492, #41381

Summary

TODO

High

  • Date filter logic broken Global search filter for "since" and "until" are broken #41492
  • Mail previews not right
  • Broken folder icon in files results
  • Messages: avatar in circles not squares
  • “Search in app” is only available for a few apps (remove links)
  • Search field is not focused automatically when the modal is opened

Medium

  • Contacts filter shouldn’t be available if contacts app is not available
  • No space for icons in modified

Low

  • Apply range primary to the right
  • Date range filter -> custom date range
  • Apply range -> Search in date range
  • "No matching results" emptycontent icon should be a search icon instead of the current one
  • Text in People" menu regular not bold
  • Close icon material design icon "close" instead of "close-thick"
  • Cursor pointer instead on hovering close icon
  • Avatar in filter chips shouldn't be clickable and size should be 24px

@nfebe
Copy link
Contributor Author

nfebe commented Nov 15, 2023

Performance

  • /providers should be called only when user interact with the search, not on every page load

UI

  • "Modified" button should be renamed as we are not always searching on a modification date

@nfebe nfebe closed this Nov 15, 2023
@nfebe nfebe reopened this Nov 15, 2023
@nfebe nfebe changed the title Improve date-range logic for global search Enhancements: Fix and updates to most recent global search UI Nov 15, 2023
@nfebe nfebe force-pushed the 41381-global-search-follow-up-2 branch 4 times, most recently from a197f95 to fc8c569 Compare November 20, 2023 10:17
@nfebe
Copy link
Contributor Author

nfebe commented Nov 20, 2023

This should get reviewed and merged, so smaller follow up prs get in faster, it makes things faster and gets as much as possible into the regular build schedule.

@nfebe nfebe added this to the Nextcloud 28 milestone Nov 20, 2023
@nfebe nfebe force-pushed the 41381-global-search-follow-up-2 branch from fc8c569 to 9609adb Compare November 20, 2023 13:17
@nfebe
Copy link
Contributor Author

nfebe commented Nov 20, 2023

/compile amend /

@nextcloud-command nextcloud-command force-pushed the 41381-global-search-follow-up-2 branch from 9609adb to 9903f35 Compare November 20, 2023 16:22
@nfebe nfebe force-pushed the 41381-global-search-follow-up-2 branch 4 times, most recently from de65ad7 to 02be261 Compare November 21, 2023 10:19
@nfebe
Copy link
Contributor Author

nfebe commented Nov 21, 2023

/compile amend /

nfebe added 2 commits November 21, 2023 11:26
@nfebe
Improve date-range logic for global search
4964cb8 
- Allow future dates in custom date range
- Fix date ranges for example, before now, today range was roughly
 between `now()` to `now() + a few milli seconds`
- Update text in custom date range modal, right align "Search in range"
 button.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
Round avatars when needed and show url-based mime icons
8dadb09 
- Pass `results.rounded` property that comes with search result
 data to determine if avatar would be rounded or not.

- Icons loaded via url's now visible.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the 41381-global-search-follow-up-2 branch from 02be261 to cb9d06d Compare November 21, 2023 10:26
@nfebe
Copy link
Contributor Author

nfebe commented Nov 21, 2023

/compile amend /

@nextcloud-command nextcloud-command force-pushed the 41381-global-search-follow-up-2 branch from cb9d06d to b1053ef Compare November 21, 2023 10:42
susnux
susnux requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing appkey for translation, this will not work :/

core/src/components/GlobalSearch/CustomDateRangeModal.vue Outdated Show resolved Hide resolved
@nfebe nfebe force-pushed the 41381-global-search-follow-up-2 branch from b1053ef to d9d2352 Compare November 21, 2023 13:23
@nfebe
Copy link
Contributor Author

nfebe commented Nov 21, 2023

/compile amend /

@nfebe @nextcloud-command
Move search result section to component & hide thumbnail if error
701e626 
The section that handles the search result list item is big and complex enough
 to have it's own component. Inside this component, a new method is added to hide
the thumbnail preview if the image load errors out.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the 41381-global-search-follow-up-2 branch from d9d2352 to 701e626 Compare November 21, 2023 13:29
@nfebe nfebe merged commit 163e8b6 into master Nov 21, 2023
@nfebe nfebe deleted the 41381-global-search-follow-up-2 branch November 21, 2023 14:26
@nfebe nfebe mentioned this pull request Nov 21, 2023
Closed
10 tasks
@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@Pytal Pytal Awaiting requested review from Pytal

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees
No one assigned
Labels
feature: search
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Global search filter for "since" and "until" are broken
3 participants
@nfebe @susnux @artonge