Regular db pings to reconnect after timed out connections #41819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
enh/reconnect-again
branch
from
f7b113a
to
cf3daaa
Compare
juliushaertl
changed the title
juliushaertl
force-pushed
the
enh/reconnect-again
branch
2 times, most recently
from
874a17a
to
e4cbdab
Compare
juliushaertl
requested review from
ChristophWurst,
nickvergessen,
icewind1991 and
sorbaugh
juliushaertl
force-pushed
the
enh/reconnect-again
branch
from
e4cbdab
to
35b2bcb
Compare
nickvergessen
approved these changes
Jan 10, 2024
ChristophWurst
approved these changes
Jan 10, 2024
|
We should probably add a check if a transaction is active and don't do automatic re-connections if so since the pending updates will be lost. |
juliushaertl
force-pushed
the
enh/reconnect-again
branch
2 times, most recently
from
44dd3cf
to
c919c78
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
enh/reconnect-again
branch
from
c919c78
to
296096e
Compare
icewind1991
approved these changes
Jan 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementation of #9425 to regularly check if the connection to the db is still active using a dummy select query (which is what the previous implementation used the ping method for which got removed from doctrine).