Check connection status and attempt to reconnect each each minute #9425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
db-reconnect-timeout
branch
from
6f778af
to
335619f
Compare
Codecov Report
@@ Coverage Diff @@
## master #9425 +/- ##
============================================
+ Coverage 51.61% 51.62% +<.01%
- Complexity 25679 25684 +5
============================================
Files 1638 1639 +1
Lines 96272 96284 +12
Branches 1393 1393
============================================
+ Hits 49695 49709 +14
+ Misses 46577 46575 -2
|
|
How will this work with transactions? |
|
It explicitly doesn't do anything while in a transaction since there is no way to resume a transaction or do any other kind of automated safe recovery. |
icewind1991
added
3. to review
rullzer
approved these changes
May 31, 2018
ChristophWurst
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to prevent "mysql has gone away" errors when there is a long time between database requests