fix(dav): Improve handling and logging of bulk upload failures #42001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
ArtificialOwl and
icewind1991
and removed request for
a team
|
/backport to stable28 |
nickvergessen
force-pushed
the
bugfix/noid/improve-logging-of-bulk-failures
branch
from
8abd748
to
ef0ebef
Compare
miaulalala
approved these changes
Dec 4, 2023
bigcat88
approved these changes
Dec 4, 2023
AndyScherzinger
approved these changes
Dec 4, 2023
|
Thank you 👍 Added a link, to the issue I created some days ago. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
AndyScherzinger
force-pushed
the
bugfix/noid/improve-logging-of-bulk-failures
branch
from
ef0ebef
to
e4460e3
Compare
nickvergessen
deleted the
bugfix/noid/improve-logging-of-bulk-failures
branch
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41464
Summary
Error from our log:
Undefined array key 1 at /var/www/cloud.nextcloud.com/nextcloud/apps/dav/lib/BulkUpload/MultipartRequestParser.php#183Now logs a more useful and explicit message allowing to find the actual issue:
so we can reach out to the desktop client team
Checklist