[stable28] fix(settings): apps list layout #44327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
added
bug
3. to review
artonge
approved these changes
Mar 19, 2024
|
Backport is not complete |
ShGKme
added
2. developing
8 tasks
8 tasks
8 tasks
4 tasks
|
@ShGKme do you think you can get this ready for 28.0.5? |
|
@ShGKme any update here? :) |
|
@ShGKme Hi Grigorii |
|
@ShGKme keep or close? |
|
Keep i hear |
|
Full backport occurs too complicated due to the large refactoring of this app in Nextcloud 29.
To make it much simpler and less risky - backporting only 1 commit that fixes the linked Safari issue with apps list scrolling, adapting it to the Nextcloud 28 state. Tested on:
Tested cases:
|
ShGKme
force-pushed
the
backport/44236/stable28
branch
from
858c61f to
0056ba7
Compare
ShGKme
added
3. to review
ShGKme
force-pushed
the
backport/44236/stable28
branch
from
0056ba7 to
bfb444c
Compare
GretaD
approved these changes
Feb 4, 2025
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
susnux
force-pushed
the
backport/44236/stable28
branch
from
bfb444c to
d14071e
Compare
|
Added screen cast of the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44236
Full backport occurs too complicated due to the large refactoring of this app in Nextcloud 29.
Complete backport with a propper solution would require backporting at least the following large PRs:
app-levela component (AppLevelBadge) #43770To make it much simpler and less risky - backporting only 1 commit that fixes the linked Safari issue with apps list scrolling, adapting it to the Nextcloud 28 state.
Tested on:
Tested cases:
Screen.Recording.2025-02-04.at.12.42.56.mov
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.