Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(encryption): Clicking default module in UI sets bogus value #44632

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[stable27] fix(encryption): Clicking default module in UI sets bogus value #44632

merged 1 commit into from
Apr 4, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 3, 2024 •
edited by joshtrichards
Loading

Backport of #44604

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the Nextcloud 27.1.9 milestone Apr 3, 2024
@artonge
Copy link
Contributor

artonge commented Apr 3, 2024

/compile amend /

@nextcloud-command nextcloud-command force-pushed the backport/44604/stable27 branch from e91a1b3 to 878b646 Compare April 3, 2024 09:33
@joshtrichards
Copy link
Member

Expected property shorthand

Not sure why this lint error is only triggering on the stable27 backport. All other branches don't care. Maybe the older rules were more sensitive regarding shorthand?

I can add an inline command that'll ignore it. Anyone have any thoughts/preferences?

@joshtrichards joshtrichards marked this pull request as ready for review April 3, 2024 15:49
@artonge artonge force-pushed the backport/44604/stable27 branch from 878b646 to ff6979f Compare April 3, 2024 16:04
@artonge
Copy link
Contributor

artonge commented Apr 3, 2024

Fixed eslint error

@artonge artonge force-pushed the backport/44604/stable27 branch 2 times, most recently from 18b5cb8 to dfa0106 Compare April 3, 2024 16:56
@artonge
fix(encryption): Clicking default module in UI sets bogus value
fe86964 
Fixes #44532

Likely fixes #43123

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the backport/44604/stable27 branch from dfa0106 to fe86964 Compare April 4, 2024 08:08
@artonge artonge added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 4, 2024
@artonge
Copy link
Contributor

artonge commented Apr 4, 2024

CI failure is unrelated

@sorbaugh sorbaugh merged commit adea4af into stable27 Apr 4, 2024
37 of 38 checks passed
@sorbaugh sorbaugh deleted the backport/44604/stable27 branch April 4, 2024 09:30
@Altahrim Altahrim mentioned this pull request Apr 17, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@joshtrichards joshtrichards joshtrichards approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@joshtrichards joshtrichards

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: encryption (server-side)
Projects
None yet
Milestone
Nextcloud 27.1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @joshtrichards @sorbaugh