-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(oc-dialog): Get rid of the overlay #44717
Conversation
- Icrement Z-index of oc-dialog-dim - Increment z-index of oc-dialog- Insert oc-dialog-dim before oc-dialog Co-authored-by: Co-author RayanBekri <rmt.bekri@gmail.com>" Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <118366366+jadjoud@users.noreply.github.com>
d87ca90
to
8e136c3
Compare
/backport to stable29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but is this issue not a good contender to replace with NcDialog?
From what I see, this functionality can be all wrapped into a custom button generated by NcDialog -> https://github.com/nextcloud/server/blob/ff2100a4e515988d3ba44c7cfe734d19a6b4b377/apps/settings/src/components/Users/UserRow.vue#L538C7-L545C10 , but again, this still works :) |
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
Screencast
After:
Checklist