Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(oc-dialog): Get rid of the overlay #44725

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 8, 2024

Backport of #44717

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, emoral435 and susnux April 8, 2024 14:02
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Apr 8, 2024
@backportbot backportbot bot added this to the Nextcloud 29 milestone Apr 8, 2024
@emoral435 emoral435 force-pushed the backport/44717/stable29 branch from 1440d5e to a18e7a7 Compare April 8, 2024 17:50
jadjoud and others added 2 commits April 8, 2024 12:50
- Icrement Z-index of oc-dialog-dim
- Increment z-index of oc-dialog- Insert oc-dialog-dim before oc-dialog

Co-authored-by: Co-author RayanBekri <rmt.bekri@gmail.com>"
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <118366366+jadjoud@users.noreply.github.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the backport/44717/stable29 branch from a18e7a7 to f5f9822 Compare April 8, 2024 17:50
@emoral435
Copy link
Contributor

manually compiled assets, seems like everything is here :)

@emoral435 emoral435 marked this pull request as ready for review April 8, 2024 17:51
@emoral435
Copy link
Contributor

Cypress (most likely) unrelated, Cypress #1 has been buggy :/

@artonge
Copy link
Contributor

artonge commented Apr 9, 2024

manually compiled assets, seems like everything is here :)

Please tick the todo :D

@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 9, 2024
@blizzz blizzz mentioned this pull request Apr 10, 2024
5 tasks
@blizzz blizzz merged commit 884eb0c into stable29 Apr 11, 2024
106 of 109 checks passed
@blizzz blizzz deleted the backport/44717/stable29 branch April 11, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants