-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(caldav): event links in shared calendar notifications #45775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
3. to review
Waiting for reviews
feature: activity and notification
feature: caldav
Related to CalDAV internals
labels
Jun 11, 2024
st3iny
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
June 11, 2024 08:10
miaulalala
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChristophWurst
approved these changes
Jun 11, 2024
st3iny
force-pushed
the
fix/caldav/event-notification-shared-calendars
branch
from
June 11, 2024 17:00
64bdf08
to
7a10312
Compare
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
st3iny
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jun 11, 2024
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/caldav/event-notification-shared-calendars
branch
from
June 11, 2024 18:10
7a10312
to
3a975d0
Compare
4 tasks
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
bug
feature: activity and notification
feature: caldav
Related to CalDAV internals
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The link in event notifications is invalid if a calendar is shared. An incoming shared calendar is belonging to sharee's principal with the custom name
<calendar>_shared_by_<sharer>
.I implemented a hack to change the link in those cases to make the links in notifications work again.
How to reproduce the bug?
Here: Clicking the link redirects to Calendar and opens the event.
Master: Clicking the link redirects to Calendar and shows an empty content
Event does not exist
.Checklist