Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): Fix missing protocol on CloudID remote #46133

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

nickvergessen
Copy link
Member

Seems that some paths inside the external storage logic don't contain the protocol. Since it's too hard to track down within the full code base, it's easier to simply enforce the protocol within the cloud ID manager.
I had ended up with:

 Undefined array key 1 at apps/files_sharing/lib/External/Cache.php#25

[, $remote] = explode('://', $cloudId->getRemote(), 2);

Checklist

@nickvergessen
Copy link
Member Author

/backport to stable29

@ArtificialOwl
Copy link
Member

faced the issue while working on https://github.com/nextcloud/server/pull/45979/files#diff-70371b3022845d468bcd2be6a3dd06d5ffe655f958f1b737bb5a107a206e3f2c
quickly fixed on my side but i guess it is now useless :)

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-missing-protocol-on-remotes branch from 3799ce8 to 280d70a Compare June 27, 2024 09:26
@nickvergessen nickvergessen merged commit 00aa8f5 into master Jun 27, 2024
162 of 165 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/fix-missing-protocol-on-remotes branch June 27, 2024 12:59
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants