fix(federation): Fix federation with Nextcloud 29.0.4 or later #12661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
regression
feature: api 🛠️
nickvergessen
force-pushed
the
bugfix/12654/fix-federation-authentication-with-https-protocol
branch
from
70d3524 to
27cd959
Compare
|
/backport to stable29 |
|
Looks good, but unit tests are failing |
Since 29.0.4 ICloudID::getRemote() contains the protocol. Therefore we can no longer find the federation invites by the server URL, as the protocol was missing in the database. To be more aligned with the future expectation of the handling, the protocol is added and now always expected. Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/12654/fix-federation-authentication-with-https-protocol
branch
from
27cd959 to
fe45a35
Compare
SystemKeeper
approved these changes
Jul 10, 2024
nickvergessen
deleted the
bugfix/12654/fix-federation-authentication-with-https-protocol
branch
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Nextcloud 29.0.4 ICloudID::getRemote() contains the protocol. Therefore we can no longer find the federation invites by the server URL, as the protocol was missing in the database.
To be more aligned with the future expectation of the handling, the protocol is added and now always expected.
☑️ Resolves
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required