Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file request dialog keeps asking for upload destination if ignored for the first time #50055

Conversation

falghamdi125
Copy link
Contributor

Hello everyone,

Summary

This PR fixes the issue in the validation process of the file request dialog. If you did not enter a destination folder and click next, the dialog fails to clear the first reported validity status.

This PR resolves an issue in the validation process of the file request dialog. Previously, if no destination folder was entered and the 'Next' button was clicked, the dialog failed to reset the initial validity status, leading to incorrect validation feedback.

What I did was:

  • Prevented going to the next step if the destination folder is invalid.
  • Added helper text to inform users that selecting the root folder is not allowed.
  • Cleared the error message and helper text once a valid path is selected.

@skjnldsv

Checklist

…estination if ignored the first time.

Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
@falghamdi125 falghamdi125 force-pushed the fix_file_request_dialog_validation branch from 8746751 to 2e30e08 Compare January 8, 2025 02:20
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv
Copy link
Member

Hey, thanks for the PR!
Unfortunately your approach isn't really fixing the real issue, which is that the custom validty needs to be reset.

Fix in #50524

@skjnldsv skjnldsv closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants