Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_sharing): file request form validity check reset #50524

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 29, 2025

Fix #48118

We need to ensure each inputs custom validity are reset before submit, so we can check them again.

As per https://developer.mozilla.org/en-US/docs/Web/API/HTMLObjectElement/setCustomValidity#examples
image

cc @myomv100

@skjnldsv skjnldsv requested a review from a team January 29, 2025 10:25
@skjnldsv skjnldsv self-assigned this Jan 29, 2025
@skjnldsv skjnldsv requested review from susnux, artonge and sorbaugh and removed request for a team January 29, 2025 10:25
@skjnldsv
Copy link
Member Author

/backport to stable30

@skjnldsv
Copy link
Member Author

/backport to stable31

@skjnldsv
Copy link
Member Author

/compile rebase

skjnldsv and others added 2 commits January 30, 2025 11:50
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/destination-drop-check branch from 78f0540 to e7d9985 Compare January 30, 2025 11:51
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 30, 2025
@skjnldsv skjnldsv merged commit af8189f into master Jan 30, 2025
120 checks passed
@skjnldsv skjnldsv deleted the fix/destination-drop-check branch January 30, 2025 12:07
@joshtrichards joshtrichards added this to the Nextcloud 32 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
5 participants