refactor(core): migrate core application to IBootstrap
#53157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
force-pushed
the
chore/refactor-core
branch
3 times, most recently
from
8e5bb02 to
d525721
Compare
susnux
requested review from
Altahrim,
come-nc,
provokateurin and
yemkareems
and removed request for
a team
4 tasks
come-nc
reviewed
Jun 2, 2025
come-nc
approved these changes
Jun 2, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Nice one 👍 🧹
Could even move the class to OC\Core\AppInfo namespace.
susnux
force-pushed
the
chore/refactor-core
branch
from
8cff3f6 to
da5f30c
Compare
Contributor
Author
Done ✅ |
susnux
force-pushed
the
chore/refactor-core
branch
from
da5f30c to
baa17ea
Compare
provokateurin
approved these changes
Jun 2, 2025
susnux
force-pushed
the
chore/refactor-core
branch
from
baa17ea to
652ba66
Compare
come-nc
reviewed
Jun 2, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/refactor-core
branch
from
38b8910 to
00d09f0
Compare
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/refactor-core
branch
from
00d09f0 to
c21e189
Compare
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve deprecation issues and makes code better maintainable by moving long event listener callbacks to dedicated listener class.
This allows us also to use bootstrap only features like the config lexicon (which needs a registration context).
Checklist