Skip to content

feat(core): Hide header in PWA #54138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

feat(core): Hide header in PWA #54138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/css/header.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/header.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,3 +267,18 @@ header .emptycontent {
width: 48px;
}
}

@media (display-mode: standalone) or (display-mode: minimal-ui) {
#header {
display: none !important;
}

#content, #content-vue {
margin-top: var(--body-container-margin);
Copy link
Contributor

@Antreesy Antreesy Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles collide, but they're not from Talk, it's all server styles imported at different order

Files Talk
Image Image

As you're using id and not class, it's by default less important, and should be forced

Suggested change
margin-top: var(--body-container-margin);
margin-top: var(--body-container-margin) !important;

Copy link
Contributor

@szaimen szaimen Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #55027

}

:root {
// Override the body height to make up for the additional height due to the missing header.
--body-height: calc(100% - env(safe-area-inset-bottom) - var(--body-container-margin) * 2) !important;
}
}
Loading
Loading