fix(l10n): Less jargon in source strings #54202
Conversation
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Looking good, let's see tests results!
skjnldsv
added
design
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Would be nice to split such changes, at least into commits but better into separate PRs.
Because you not only change l10n strings as the commit and the PR suggests, but also remove user notifications from the actions.
So e.g. on PR with only the string change + one PR with removing notifications.
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
I am not sure about the removed cancellation notifications, as I remember we had requests to explicitly add those to make clear whats going on.
Otherwise just a few comments.
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Good on removing the overbearing notifications. For the record @susnux yes we did talk about it and also had a request for it, but in practice this proves to be super annoying and results in notification fatigue and missing actually important notifications. :\
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Really good also on the general simpler wording @kra-mo :) makes everything much easier to read.
I think it is totally fair to show toasts for actions that aren't all that visible and that you might miss otherwise, but for cancellation of actions, you can see the dialog disappear. There already is visual confirmation, I don't think anyone would miss the toasts there. |
I fully support this. What is the background of these changes? I would like us to work on the Guidelines so that all apps here are better and more consistent. |
Sure, I completely agree. This is a bit of a personal initiative of mine to improve strings across Nextcloud, I started with |
nextcloud-command
force-pushed
the
fix/less-words
branch
from
bde46ed to
691ebea
Compare
|
Testes in |
Could you help me with that? I tried to look but couldn't find anything. And the e2e one seemed to be failing for other PRs too, but maybe that was unrelated? |
rakekniven
force-pushed
the
fix/less-words
branch
from
96b79b8 to
7b1ff45
Compare
|
/compile rebase |
This removes: - “enable” for settings - “settings” for settings sections - “all” when there is no obvious subset of items - “show” and “open” for navigation actions - “changes” for applying/discarding - “to clipboard” when copying - Explaining things that cannot happen - Explaining things twice, right below each other - Unnecessary technical jargon - Text that sounds like marketing copy and serves no other purpose Signed-off-by: kramo <git@kramo.page>
|
/compile rebase |
|
@kra-mo Cypress is related because this string changed: |
Ah, thank you. Let me try and fix it. |
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
|
/compile rebase |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Thanks everyone for the help 🥹 |
Follow-up to #54202 Actually seeing these in production made me realize that they look awkward without a capital letter at the start. Signed-off-by: kramo <git@kramo.page>
Resolves #53775
Summary
Removes:
If there is anything in particular that was there for a specific reason, please do tell me.
Checklist