fix(auth): remove legacy session credential fallbacks and improve code clarity #55722
+219
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e clarity Removes no longer needed legacy fallback (used only for v19->v20). Explicitly handles JSON decode failures. Includes minor readability improvements, such as splitting out session fallback (non-legacy) into a dedicated function. Updates and streamlines docblocks. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
ChristophWurst,
juliusknorr,
kesselb,
lmamane,
nickvergessen and
yemkareems
joshtrichards
added
enhancement
3. to review
Signed-off-by: Josh <josh.t.richards@gmail.com>
Removed redundant condition from Store.php in psalm baseline. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
3. to review
joshtrichards
requested review from
icewind1991 and
salmart-dev
and removed request for
a team
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Outside of dropping the no longer applicable v19 legacy fallback behavior, there should be no breaking changes here. Other changes are purely code readability (e.g. re-ordering, separation of concerns, adjusting logic to not need temporary flag variable, minimize nesting, short/focused docblocks).
TODO
Checklist
3. to review, feature component)stable32)