Send an email once a file/folder is shared with a user

[MorrisJobke]

• only if user has set an email address
• only for user shares (no group shares for now)

The sharing email is basically the same as for the "share by email". 😉

[MorrisJobke]

Tested with an instance with index.php and without. Worked both fine:

[mario]

Considering there is only one available action, putting "Click the button below to open it" (also what is "it"?) is redundant. Please remove that part.

[mario]

Actually, like mentioned in the chat, the entire body text is largely useless and redundant.

[MorrisJobke]

Then the email looks super empty. I guess we need some adjusted text in there (also it avoid to be classified as spam, because they check for a given word count sometimes).

[mario]

The white rectangle is also ugly. Maybe just button below the text?

…

On Thu, 27 Jul 2017 at 12:21, Morris Jobke ***@***.***> wrote: Then the email looks super empty. I guess we need some adjusted text in there (also it avoid to be classified as spam, because they check for a given word count sometimes). [image: bildschirmfoto 2017-07-27 um 12 20 50] <https://user-images.githubusercontent.com/245432/28666066-268209d6-72c6-11e7-8495-0c6d5f3cc8fc.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5897 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAWsgw6YjDJXfAzYX6vbkYid_X6s8X5ks5sSGS9gaJpZM4Okiiq> .

[MorrisJobke]

The white rectangle is also ugly. Maybe just button below the text?

This is super hard to accomplish due to the weird stuff, that HTML emails need to be compatible with the new stuff like gmail and the old stuff like Outlook (old regarding rendering engine).

[LukasReschke]

😀

[schiessle]

In the default activity settings email notifications are enabled for "A file or folder has been shared". Does this mean that users will get now two mails by default. One immediately after the share was created and one later when the activity mails are send out?

[MorrisJobke]

Does this mean that users will get now two mails by default. One immediately after the share was created and one later when the activity mails are send out?

Seems so. We should disable the activity email then.

[MorrisJobke]

This would then look like this:

I still don't like it. Can we get this in like it is now, because those are already the emails that are send out for email shares and then do the rewording in an additional step? Thanks

[codecov]

Codecov Report

Merging #5897 into master will decrease coverage by 0.01%.
The diff coverage is 29.16%.

@@             Coverage Diff              @@
##             master    #5897      +/-   ##
============================================
- Coverage      53.2%   53.18%   -0.02%     
- Complexity    22759    22766       +7     
============================================
  Files          1404     1404              
  Lines         87529    87576      +47     
  Branches       1327     1327              
============================================
+ Hits          46570    46578       +8     
- Misses        40959    40998      +39

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Server.php	93.75% <100%> (+0.02%)	121 <0> (ø)	⬇️
lib/private/Share20/Manager.php	89.07% <22.72%> (-5.14%)	229 <3> (+7)
core/js/js.js	61.27% <0%> (-0.56%)	0% <0%> (ø)

[mario]

@MorrisJobke sure. Would you be so kind to open an issue with all emails that we send like this (and assign them to me) so I can re-word them together with you? :)

[schiessle]

Seems so. We should disable the activity email then.Seems so. We should disable the activity email then.

I fear that this will always lead to confusions because with this PR we only send notifications for individual shares, so if someone want to have notification about group shares they have to enable the activity settings which will then lead to duplicates for individual shares. Maybe we should reduce the activity mails than to non-individual shares only... But this will also be confusing "why can I disable mails for group shares but not for individual shares"?

In general I really like the idea about direct mail notifications for shares as introduced here but I fear that we create two parallel worlds of notifications which will become quite confusing.

As a minimum I would suggest to change at least the activity defaults within this PR to disable activity mails for shares.

[LukasReschke]

I still don't like it. Can we get this in like it is now, because those are already the emails that are send out for email shares and then do the rewording in an additional step? Thanks

👍 🙈

[MorrisJobke]

I fear that this will always lead to confusions because with this PR we only send notifications for individual shares, so if someone want to have notification about group shares they have to enable the activity settings which will then lead to duplicates for individual shares.

I would simply add group emails as well, but those need more code and those I would also not backport. 😉

In general I really like the idea about direct mail notifications for shares as introduced here but I fear that we create two parallel worlds of notifications which will become quite confusing.

Of course we should streamline everything.

As a minimum I would suggest to change at least the activity defaults within this PR to disable activity mails for shares.

I thought the activity defaults are set in the activity app. Let me create a PR there.

[MorrisJobke]

I thought the activity defaults are set in the activity app. Let me create a PR there.

Was done in files_sharing. So I added a commit here.

[rullzer]

Fine lets get this in. Then I'll spend some time getting more event ready so we can decouple this.

[LukasReschke]

Pro-tip: If CI says stuff doesn't work then don't merge it. This here is broken.

[jancborchardt]

@MorrisJobke @mario if there is that wording discussion issue please CC me. I also agree the notification mails should be cleaner, but of course also not too empty. :) We could think about using filetype icons, or even generated previews.