Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IUser #5949

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Use IUser #5949

merged 1 commit into from
Aug 2, 2017

Conversation

LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Aug 1, 2017

This is broken and will never work as the phan CI step pointed out at https://drone.nextcloud.com/nextcloud/server/523/48

lib/private/Share20/Manager.php:720 PhanUndeclaredClassInstanceof Checking instanceof against undeclared class \OC\Share20\IUser

Pro-tip of the day: Check why CI fails before merging 🙈

Looking at @MorrisJobke and @rullzer for a review 😉

@MorrisJobke
Copy link
Member

Ref #5897

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 1, 2017

This is broken and will never work

PHP has forgiven this and just continued 🙈 It actually worked, but has written a warning 🙈

@LukasReschke LukasReschke added the 4. to release Ready to be released and/or waiting for tests to finish label Aug 1, 2017
This is broken and will never work as the phan CI step pointed out.

Pro-tip of the day: Check why CI fails before merging 🙈

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@codecov
Copy link

codecov bot commented Aug 2, 2017

Codecov Report

Merging #5949 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5949   +/-   ##
=========================================
  Coverage     53.05%   53.05%           
  Complexity    22764    22764           
=========================================
  Files          1404     1404           
  Lines         88109    88109           
  Branches       1327     1327           
=========================================
  Hits          46748    46748           
  Misses        41361    41361
Impacted Files Coverage Δ Complexity Δ
lib/private/Share20/Manager.php 88.63% <ø> (ø) 229 <0> (ø) ⬇️
apps/files_external/lib/Lib/Storage/SMB.php 50.94% <0%> (-0.38%) 116% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit a96c651 into master Aug 2, 2017
@MorrisJobke MorrisJobke deleted the fix-broken-code branch August 2, 2017 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug high regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants