-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11] timespan check #6897
Merged
Merged
[11] timespan check #6897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Codecov Report
@@ Coverage Diff @@
## stable11 #6897 +/- ##
==============================================
- Coverage 57.54% 57.48% -0.06%
- Complexity 19499 19508 +9
==============================================
Files 1163 1220 +57
Lines 65984 72830 +6846
Branches 0 1239 +1239
==============================================
+ Hits 37971 41868 +3897
- Misses 28013 30962 +2949
|
I added the unit tests from #6913 😉 |
MorrisJobke
approved these changes
Oct 23, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
nickvergessen
approved these changes
Oct 23, 2017
MorrisJobke
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6837 and #6896. This change is needed for the polls app also in current releases.
Hope I did the backport request correctly.